feat: align ui-kit password policy, wire useAccountData to horizon client, and connect validation.rs helpers - #1433
Open
linesofcodes0-cloud wants to merge 1 commit into
Conversation
…ient, and connect validation.rs helpers (fixes ancore-org#1405, ancore-org#1408, ancore-org#1409, ancore-org#1402)
|
@linesofcodes0-cloud Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves issues #1405, #1408, #1409, and #1402 across
@ancore/ui-kit,@ancore/web-dashboard, andcontracts/account.UI-KIT Password Policy Alignment (Fixes [UI-KIT] Form/validation.ts's exported passwordSchema/getPasswordStrength duplicate password policy with materially weaker rules than the canonical @ancore/crypto implementation #1405):
@ancore/ui-kit'spasswordSchemaandgetPasswordStrengthto import and enforce@ancore/crypto's canonicalvalidatePasswordStrengthimplementation.Web Dashboard Account Data & Horizon Integration (Fixes [WEB-DASHBOARD] useAccountData hook is fully mocked and wired into two real pages (Dashboard, Account) #1408, [WEB-DASHBOARD] lib/horizon.ts is dead code — a fully-implemented Horizon client with zero importers anywhere in the app #1409):
$1250.75mock data andMOCK_TRANSACTIONSfromuseAccountData.ts.useAccountDatato callfetchAccountDatafromapps/web-dashboard/src/lib/horizon.ts.apps/web-dashboard/src/lib/__tests__/horizon.test.tsto coverfetchAccountBalance,fetchAccountData, andgetHorizonUrl.Contract Validation Helper Integration (Fixes [CONTRACT] validation.rs's trust-boundary helper functions are dead code — lib.rs re-implements the same checks inline, diverging from what's actually tested #1402):
contracts/account/src/lib.rsto callvalidation.rspure trust-boundary helper functions (validation::nonce_matches,validation::session_key_is_expired,validation::allowlist_permits_address,validation::validate_expiry).Closes #1405
Closes #1408
Closes #1409
Closes #1402