fix(datapack): clear client registry on disconnect

[duzos]

fixes #26

Server-synced datapack entries were leaking into the next world / singleplayer because the client registry was never cleared on disconnect and the cache clear in readFromServer was commented out. Clicking a leaked (server-only) entry in singleplayer crashed the game.

Changes in SimpleDatapackRegistry:

• Register ClientPlayConnectionEvents.DISCONNECT in onClientInit() to clearCache() then re-apply defaults().
• Un-comment this.clearCache() at the start of readFromServer so server data replaces cleanly instead of merging with leaked state.

Verified with ./gradlew compileJava (BUILD SUCCESSFUL).

[Copilot]

Pull request overview

Fixes a client-side datapack registry leak where server-synced entries persisted into subsequent singleplayer worlds, potentially causing crashes when interacting with server-only entries.

Changes:

• Clear and reinitialize the client registry on disconnect via ClientPlayConnectionEvents.DISCONNECT.
• Ensure server sync fully replaces client state by clearing the cache at the start of readFromServer.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[duzos]

copilots latest review didnt post its thread (same github-mcp-server: Azure AI Agent request failed), noting it here - the concurrency comment was valid and is fixed in 52b3d9f:

• the copied PacketByteBuf was never released (netty buffer leak) -> now released in a finally.
• the deferred client.execute could run after a disconnect and repopulate the registry with stale server data -> now skips if client.getNetworkHandler() != handler.

./gradlew compileJava green.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.