Split Ambion package into application, host, protocol, and Node entry points - #73
Open
andreisavu wants to merge 1 commit into
Open
Split Ambion package into application, host, protocol, and Node entry points#73andreisavu wants to merge 1 commit into
andreisavu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
packages/ambion/src/index.ts) to export only the application primitives (defineAgent,defineHuman,defineTool,defineWorkspace,startSession) and the narrow set of types needed to call them and consume their results.packages/ambion/src/host.ts,packages/ambion/src/protocol.ts, andpackages/ambion/src/node.ts, and wiredpackage.jsonexports for./host,./protocol, and./nodeso hosts and adapters import the correct surface.SeatActorclass with a host-facing factorycreateSeatActor(...)and removed direct re-exports of Pi internals from the application default export, keeping those insrc/internal.tsfor tests and internal usage.protocolentry point, runtime and storage adapters (includingsqliteSessions) to thehostentry point, and Node workspace adapters (memoryBackend,directoryBackend) to thenodeentry point.packages/ambion/test/package.test.ts) that asserts exact export lists for the default application entry point and thehost,protocol, andnodeentry points to prevent API regressions.Testing
pnpm --filter @ambionframework/ambion run check:types— succeeded.pnpm --filter @ambionframework/ambion run build— succeeded and emitted the newdistartifacts for the new entry points.pnpm --filter @ambionframework/ambion test— executed for the ambion package (no failures observed in this run).pnpm --filter @ambionframework/cloudflare run check:types— failed in this environment due to missing Cloudflare-specific type libraries and local package install; this is an environment/dependency issue rather than a change in the adapter code.Codex Task