Fix Makefile pod name

[andybraren]

I notice that a bunch of our recent PRs are failing one of their checks. According to Claude's analysis:

Summary
Problem: The test-local-dev-simulation job was failing because the Makefile was looking for pods with label app=backend, but the actual backend deployment uses app=backend-api.
Evidence: The troubleshooting output showed all pods were actually ready (1/1 Running, Ready: True), but the test was using the wrong label selector and couldn't find them.
Fix: Updated the Makefile in two locations:
Line 359 - local-test-quick target: Changed app=backend → app=backend-api
Line 606 - _auto-port-forward target: Changed app=backend → app=backend-api
This aligns the Makefile with the actual label used in components/manifests/base/backend-deployment.yaml. The test should now pass in CI. ✅

If this sounds right to folks then this PR should fix it. Let's see if it passes now.

EDIT: it does. 🎉

[github-actions]

Claude Code Review

Summary

This PR fixes a failing CI test by correcting a pod label selector in the Makefile. The change aligns the Makefile with the actual label used in the backend deployment manifest (app=backend-api instead of app=backend).

Change: 1 line modified in Makefile (line 630)
Impact: Fixes the test-local-dev-simulation CI check that was failing on recent PRs
Status: ✅ CI now passing

---

Issues by Severity

🚫 Blocker Issues

None found.

🔴 Critical Issues

None found.

🟡 Major Issues

None found.

🔵 Minor Issues

None found.

---

Positive Highlights

1. Excellent Problem Diagnosis - Correctly identified the root cause through CI investigation and troubleshooting output analysis
2. Minimal, Surgical Fix - Changed exactly what was needed, nothing more
3. Verified Fix - Confirmed the fix works in CI before submitting
4. Clear Documentation - PR description explains the problem, evidence, and solution clearly
5. Consistency - Aligns Makefile with the source of truth (components/manifests/base/backend-deployment.yaml)

---

Code Quality Assessment

✅ Follows Repository Standards

• Makefile Conventions: Uses correct namespace variable ($(NAMESPACE))
• Label Consistency: Matches deployment manifest labels exactly
• Git Workflow: Uses feature branch (fix-local-dev-test) per standards
• Commit Style: Clear, concise commit message

✅ Security

• No security implications (infrastructure-only change)
• No credentials, tokens, or sensitive data involved

✅ Testing

• CI Validation: The fix has been verified in CI - tests now pass
• Scope: Change only affects local dev and CI test automation
• Risk: Extremely low - only affects kubectl wait command label selector

✅ Architecture

• Follows established Makefile patterns
• No architectural concerns

---

Recommendations

Immediate Actions

✅ READY TO MERGE - No changes needed. This is a clean, well-executed fix.

Future Improvements (Optional, Not Required for This PR)

1. Label Audit: Consider running a quick audit to ensure all label selectors across the codebase (Makefile, scripts, docs) match the deployment manifests. This would prevent similar issues in the future.

2. Documentation: The dev-logs and dev-test targets in the Makefile might benefit from inline comments noting the label values they depend on, making future maintenance easier.

Example:

# Note: Backend pods use label app=backend-api (see components/manifests/base/backend-deployment.yaml)
kubectl wait --for=condition=ready pod -l app=backend-api -n $(NAMESPACE) --timeout=60s

---

Final Verdict

Recommendation: ✅ APPROVE AND MERGE

This is a textbook example of a good bug fix:

• Identified the problem through evidence-based analysis
• Made a minimal, targeted change
• Verified the fix works
• Documented the reasoning clearly

Great work! 🎉

---

🔍 View AI decision process (logs available for 90 days)

📋 View memory system files loaded (click to expand)

What Amber Loaded for Code Review

Amber automatically loaded these repository standards from the memory system:

1. CLAUDE.md - Master project instructions, development standards
2. backend-development.md - Go backend, K8s integration patterns
3. frontend-development.md - NextJS, Shadcn UI, React Query patterns
4. security-standards.md - Auth, RBAC, token handling
5. k8s-client-usage.md - User token vs service account patterns
6. error-handling.md - Consistent error patterns
7. react-query-usage.md - Data fetching patterns

Impact: This review used your repository's specific code quality standards, security patterns, and best practices from the memory system (PRs #359, #360) - not just generic code review guidelines.

[bobbravo2]

This should be obsolete now: #460 has all checks passing.

@andybraren please 💀 keep alerting us if we see regressions or checks starting to go 🔴. Thank you!