Add timestamps to default logger#4
Merged
Merged
Conversation
Requested by @tjschutte. - Does not change API for existing dependants; defaults to False - Exposes option to add timestamp to logs
lazamar
requested changes
Feb 20, 2026
Contributor
Author
|
will do
…On Fri, Feb 20, 2026 at 12:48 PM Marcelo Lazaroni ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In ambar-hs-utils/src/Util/Logger.hs
<#4 (comment)>:
> -- | Log up to a set log level, including location for errors and debugging.
-- Serializes all logs, making it not suitable for high performance logging.
plainLogger :: Severity -> SimpleLogger
-plainLogger maxSeverity =
+plainLogger maxSeverity = plainLoggerWith maxSeverity defaultLoggerOpts
+
+plainLoggerWith :: Severity -> LoggerOpts -> SimpleLogger
+plainLoggerWith maxSeverity opts =
The idea of this module is that it already provides the parts the consumer
can use to create the logger they want. The plainLogger is just a
convenience for us with some preset choices so no need to be very
configurable.
In AWS we didn't need the timestamps. If we will need it in our infra we
can just add them to plainLogger directly.
—
Reply to this email directly, view it on GitHub
<#4 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABWCUXJLN3QCSHC6YN6NYH34M5XLVAVCNFSM6AAAAACV23ET6OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQMZUGE2TCNRQGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Per Marcelo's PR feedback.
EthanRBrown
changed the title
lazamar
approved these changes
Feb 21, 2026
EthanRBrown
added a commit
to ambarltd/emulator
that referenced
this pull request
Feb 21, 2026
This updates the haskell-libs dep to include [this PR](ambarltd/haskell-libs#4), which adds timestamps to the default logger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds timestamp to default logger.
Requested by @tjschutte.