Skip to content

fix: stabilize tab rename editing#109

Closed
bvolpato wants to merge 1 commit into
am-will:mainfrom
bvolpato:bvolpato/fix-tab-rename-focus
Closed

fix: stabilize tab rename editing#109
bvolpato wants to merge 1 commit into
am-will:mainfrom
bvolpato:bvolpato/fix-tab-rename-focus

Conversation

@bvolpato

@bvolpato bvolpato commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes tab inline rename getting stuck or stacking duplicate editors after repeated right-click Rename actions.

Changes

  • Reuse and refocus an existing tab rename entry instead of inserting another one.
  • Make the tab label wrapper targetable while editing so the entry can keep pointer/focus events.
  • Defer opening the rename editor until the context-menu popover has released its grab.
  • Suppress tab drag/activation gestures while the rename entry is active.
  • Anchor glad loader symbols so host builds link cleanly against libghostty.so.

Repro Steps

  1. Open Limux with at least one terminal tab.
  2. Right-click a tab and choose Rename.
  3. Right-click the same tab while rename is active and choose Rename again.
  4. Before this fix, multiple inline editors could stack and focus/cursor handling could get stuck.
  5. After this fix, the existing editor is reused and remains editable.

Testing

  • ./scripts/check.sh
  • cargo build -p limux-host-linux
  • LIMUX_SMOKE_PROFILE=debug ./scripts/xvfb-smoke-test.sh attempted locally; host builds and launches, but the smoke flow stops before agent stages because Ghostty surface creation fails under Xvfb with limux: failed to create ghostty surface.

Did this cause any problems?

Rollback/revert this commit and redeploy the service.

Prevent repeated Rename actions from stacking inline tab rename entries, keep the edit wrapper targetable while typing, and defer focus until the popover grab closes.

Anchor glad loader symbols so host builds link with libghostty.so.
@am-will

am-will commented Jul 6, 2026

Copy link
Copy Markdown
Owner

Thanks for putting this together. I pushed a combined version of the tab rename lifecycle fix to main in f679daf: it keeps your duplicate-editor prevention, popover idle deferral, targetability, and gesture/drag suppression direction, and folds in the hover-focus and idle blur cleanup needed for the broader #91 scenario.

Validation: ./scripts/check.sh passes. The local Xvfb smoke can start the live bridge with GDK_BACKEND=x11, but still cannot create Ghostty surfaces under Xvfb here, so please test the next update in a real session if you can.

@bvolpato

bvolpato commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @am-will ! Closing this

@bvolpato bvolpato closed this Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants