fix: stabilize tab rename editing#109
Closed
bvolpato wants to merge 1 commit into
Closed
Conversation
Prevent repeated Rename actions from stacking inline tab rename entries, keep the edit wrapper targetable while typing, and defer focus until the popover grab closes. Anchor glad loader symbols so host builds link with libghostty.so.
Owner
|
Thanks for putting this together. I pushed a combined version of the tab rename lifecycle fix to main in Validation: |
Contributor
Author
|
Thanks @am-will ! Closing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes tab inline rename getting stuck or stacking duplicate editors after repeated right-click Rename actions.
Changes
libghostty.so.Repro Steps
Testing
./scripts/check.shcargo build -p limux-host-linuxLIMUX_SMOKE_PROFILE=debug ./scripts/xvfb-smoke-test.shattempted locally; host builds and launches, but the smoke flow stops before agent stages because Ghostty surface creation fails under Xvfb withlimux: failed to create ghostty surface.Did this cause any problems?
Rollback/revert this commit and redeploy the service.