Additional ground nogoods generated for choice rules#284
Draft
Additional ground nogoods generated for choice rules#284
Conversation
29734f7 to
c468c80
Compare
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
============================================
+ Coverage 77.46% 77.48% +0.02%
- Complexity 2312 2316 +4
============================================
Files 178 179 +1
Lines 7782 7792 +10
Branches 1352 1353 +1
============================================
+ Hits 6028 6038 +10
Misses 1334 1334
Partials 420 420
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to #282 which aims for the same goal. In comparison, this pull request is (at least currently) less cleanly implemented, but is more efficient (because ground binary nogoods are directly created instead of generating constraints which lead to larger nogoods).
For a discussion, see #282.