Draft
Conversation
- Add non-projective condition to NonGroundRule. - Extend ProgramAnalysis.
- NoGood can create supports with more literals. - ProgramAnalysis computes rules deriving same head. - CompletionGenerator added to generate some completion nogoods. - NoGoodGenerator utilizes CompletionGenerator.
- Disable SolverStatisticsTests for now.
- Assignment/TrailAssignment respects excluded atoms when MBT-assigned is searched. - CompletionGenerator removes no longer needed partial completions. - NaiveGrounder/ProgramAnalyzingGrounder provides facilities to complete and ground the rules for a given atom. - DefaultSolver optionally justifies MBT at fixpoint using completion.
Make completion and justifications configurable from CLI.
- Add DirectFunctionalDependency with basic FD discovery. - NoGoodGenerator can stop ignoring of rules that cannot fire. - Bugfix in DefaultSolver.
- EnumerationAtom provides reverse lookup of enumerated terms. - DirectFunctionalDependency considers EnumerationLiterals, and ComparisonLiterals are rewritten if they provide more dependencies. - EquationRefactoring provides actual rewriting of equations.
enable completion/justification at conflict after closing by default. - CommandLineParser allows disabling of backwards completion. - ProgramAnalysis computes rules actually unifying with given head atom. - CompletionConfiguration ensures completion is enabled if specific one is set to be enabled. - CompletionGenerator respects completion settings, records completed atoms and reports them upon request. - GrounderFactory forwards CompletionConfiguration. - NaiveGrounder forwards completed atoms, has CompletionConfiguration. - NoGoodGenerator bug fixed. - ProgramAnalyzingGrounder interface extended for newly completed atoms. - DefaultSolver respects completion configuration; tries to complete all MBT-assigned atoms; at conflict after closing completion/justification also runs now. - Alpha forwards parsed CompletionConfiguration to GrounderFactory. - CompletionConfiguration used in NaiveGrounderTest and AggregatesTest.
# Conflicts: # src/main/java/at/ac/tuwien/kr/alpha/config/CommandLineParser.java
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
============================================
+ Coverage 77.46% 77.79% +0.33%
- Complexity 2312 2422 +110
============================================
Files 178 182 +4
Lines 7782 8170 +388
Branches 1352 1422 +70
============================================
+ Hits 6028 6356 +328
- Misses 1334 1370 +36
- Partials 420 444 +24
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add additional completion nogoods.