Skip to content

Update port-helper-attribute-field.js#1141

Open
cecilialam wants to merge 1 commit into
alohaeditor:devfrom
cecilialam:patch-2
Open

Update port-helper-attribute-field.js#1141
cecilialam wants to merge 1 commit into
alohaeditor:devfrom
cecilialam:patch-2

Conversation

@cecilialam

Copy link
Copy Markdown
Contributor

Allow the placeholder attribute in the AttributeField class. This is for adding the Placeholder to the table summary text field in the Aloha toolbar.

@GenticsDev

Copy link
Copy Markdown
Contributor

test

cecilialam added a commit to cecilialam/Aloha-Editor that referenced this pull request Mar 24, 2014
This is related to Update port-helper-attribute-field.js alohaeditor#1141. I am adding a placeholder message to the Table Summary textbox on the toolbar.
@Jotschi

Jotschi commented Mar 26, 2014

Copy link
Copy Markdown
Contributor

test this please

@GenticsDev

Copy link
Copy Markdown
Contributor

✘ Test failed.
Refer to this link for build results: http://jenkins.office:8080/job/alohaeditor-upstream-pullrequests/82/

@Jotschi

Jotschi commented Mar 27, 2014

Copy link
Copy Markdown
Contributor

The repository timeout test failed. This might be a glitch. I'll rerun the tests.

@Jotschi

Jotschi commented Mar 27, 2014

Copy link
Copy Markdown
Contributor

test this please

@GenticsDev

Copy link
Copy Markdown
Contributor

✔ Test passed.
Refer to this link for build results: http://jenkins.office:8080/job/alohaeditor-upstream-pullrequests/83/

@GenticsDev

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

1 similar comment
@GenticsDev

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants