Fix iOS CocoaPods wrapper double compile#467
Merged
alnitak merged 1 commit intoMay 24, 2026
Merged
Conversation
Owner
|
Hi @DavidPluxia, thanks a lot for this PR! Do you think this fix should also be made for macOS? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flutter_soloud.mmwrapper from the iOS CocoaPods targetlibflutter_soloud_plugin.aDetails
flutter_soloud.mmincludes the full C++ implementation so SwiftPM can build the package from that wrapper source. The iOS CocoaPods podspec also builds the implementation throughbuild_cmake.shand then force-loadslibflutter_soloud_plugin.ainto the app target. When CocoaPods also compilesflutter_soloud.mm, the same implementation is present twice.This keeps the wrapper file in the package for SwiftPM, but uses CocoaPods'
exclude_filesto keep it out of the CocoaPods compile sources.Validation
ruby -c ios/flutter_soloud.podspecpod ipc spec ios/flutter_soloud.podspecNO_XIPH_LIBS=1 pod ipc spec ios/flutter_soloud.podspecFlutterpod:pod install, then verified generatedPods.xcodeprojreferencesminiaudio_objc_prefix.handlibflutter_soloud_plugin.a, but noflutter_soloud.mm