Repository navigation
Add requires_streaming opt-in for custom Responses providers - #2041
Open
mortang2410 wants to merge 3 commits into
Open
mortang2410 wants to merge 3 commits into
mortang2410 wants to merge 3 commits into
Conversation
|
mortang2410 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 3 selected item(s). |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
requires_streamingto custom provider entries so a customopenai-responsesprovider can opt into SSE streaming. Built-in presets ignore the field, custom providers that omit it stay non-streaming, and the Chat Completions path is unchanged.Closes #2040
Changes
stream: truewhen the resolved endpoint requires streaming.extra_body.streamis not a second opt-in, and assert the resolved flag for every client case instead of keying off a subtest name.Verification
go test ./internal/llm/... ./cmd/opencodereview/...passes.go vet ./...passes.extra_body.streamas a second opt-in, and leaking the field into a built-in preset.Review closure
The code review confirmed and fixed seven findings across two rounds. One finding was rejected on scope because the settled requirements do not require rejecting the field on a non-Responses custom provider. The final round repeated the test-sensitivity and corpus-gap class from the first round, so the repeated-class gate stopped the loop. No open finding remains and no further reviewer round was dispatched.
Commits