Skip to content

docs(skill): respect review-only intent for mispositioned findings - #2037

Open
prascli wants to merge 2 commits into
alibaba:mainfrom
prascli:fix/review-only-intent-no-line-numbers
Open

prascli wants to merge 2 commits into
alibaba:mainfrom
prascli:fix/review-only-intent-no-line-numbers

Conversation

@prascli

@prascli prascli commented Nov 22, 2026

Copy link
Copy Markdown

Description

The "Handling mispositioned comments" section instructs the agent to apply a fix when a review comment has start_line and end_line both set to 0. That contradicts Step 4, which requires user authorization before edits in a review-only request. An agent following the more specific procedure could treat missing line numbers as permission to edit.

This change makes the procedure respect review-only intent: verify and report the location, and apply a fix only when the user has authorized edits under Step 4. The same text is updated in both the skill and its bundled plugin copy.

Fixes #2034

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring (no functional changes)
  • Documentation update
  • CI / Build / Tooling

How Has This Been Tested?

Documentation-only change; no code paths affected.

  • make test passes locally
  • Manual testing (describe below)

Verification

Reviewed the rendered diff and confirmed both skill copies are consistent.

$ git diff --stat

Checklist

  • My code follows the project's coding style (go fmt, go vet)
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the documentation accordingly (if applicable)
  • I have signed the CLA
  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Prepared with an AI assistant under human review.

Related Issues

Fixes #2034

…libaba#2034)

Signed-off-by: Indra Prasetya <11029197+prascli@users.noreply.github.com>
@CLAassistant

CLAassistant commented Nov 22, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions

Copy link
Copy Markdown
Contributor

✅ OpenCodeReview: Review skipped: no items were selected.

@prascli prascli closed this Nov 22, 2026
…libaba#2034)

- Update both skill copies (core + plugin) with PR alibaba#2036 wording
- Step 4: verify location and report finding; report at file level if uncertain
- Step 5: apply fix only when user authorized edits under Step 4
@prascli prascli reopened this Nov 22, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Respect review-only intent when a finding has no line numbers

2 participants