Repository navigation
Conversation
…libaba#2034) Signed-off-by: Indra Prasetya <11029197+prascli@users.noreply.github.com>
Contributor
|
✅ OpenCodeReview: Review skipped: no items were selected. |
…libaba#2034) - Update both skill copies (core + plugin) with PR alibaba#2036 wording - Step 4: verify location and report finding; report at file level if uncertain - Step 5: apply fix only when user authorized edits under Step 4
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The "Handling mispositioned comments" section instructs the agent to apply a fix when a review comment has
start_lineandend_lineboth set to0. That contradicts Step 4, which requires user authorization before edits in a review-only request. An agent following the more specific procedure could treat missing line numbers as permission to edit.This change makes the procedure respect review-only intent: verify and report the location, and apply a fix only when the user has authorized edits under Step 4. The same text is updated in both the skill and its bundled plugin copy.
Fixes #2034
Type of Change
How Has This Been Tested?
Documentation-only change; no code paths affected.
make testpasses locallyVerification
Reviewed the rendered diff and confirmed both skill copies are consistent.
Checklist
go fmt,go vet)Prepared with an AI assistant under human review.
Related Issues
Fixes #2034