chore(ckpt): release v0.4.3 - #2727
Conversation
|
Yuanhong Peng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7420683dba
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
kongche-jbw
left a comment
There was a problem hiding this comment.
Review baseline: c26b6fd20390...7420683dbaf3
[P1] 按规范重写 0.4.3 发布说明
src/ws-ckpt/CHANGELOG.md:7 新增的 Features / Bug Fixes 与仓库要求的
Keep a Changelog Added / Fixed 标题不一致;第 11–15 行又主要描述
accept loop、direct-IO 和 bootstrap 等实现细节,没有说明用户能观察到的改善。
发布后用户无法据此判断内存增长、性能退化和启动失败等问题在何种场景下已解决,
src/ws-ckpt/CHANGELOG_zh.md:7 的对应条目也存在同样问题。
Possible direction: 改用规范章节名,将中英文条目都改为触发场景及用户可观察结果,
并补充组件 CHANGELOG 的格式回归检查。
|
@kongche-jbw 感谢 review,两点都已修复:
|
kongche-jbw
left a comment
There was a problem hiding this comment.
Review baseline: c26b6fd20390...21bd181defde
[P1] 不要把整体延迟改善写成 p99 改善
src/ws-ckpt/CHANGELOG.md:12 和 CHANGELOG_zh.md:14 把 #2523 写成 p99
降低最多 5 倍,但该 PR 的约 5 倍数据是 fio 压力下 checkpoint 延迟从
305.10 ms 降至 62.55 ms。它只列出修复后的 p99 为 237 ms,与 btrfs-base
相同,没有提供修复前 p99,因此当前发布说明承诺了未经测量的尾延迟改善。
Possible direction: 删除 p99,按 #2523 的实际指标同步修正中英文和 RPM
changelog;若保留量化结论,请补充对应 benchmark 证据,并在 release 检查中
核对量化指标与引用 PR 的数据。
fa184a9 to
91bbc90
Compare
kongche-jbw
left a comment
There was a problem hiding this comment.
Review baseline: 702b26bb680e...91bbc901f49c
未发现阻塞问题。
Remaining risks:
Test ws-ckpt当前在未改动的dispatcher.rs:444因 Clippy 告警失败,
后续测试及 coverage gates 未运行。license/cla仍为 pending。
Verification scope:
- 复查了完整九文件 diff、全部评论与 review threads,以及六个关联 PR。
- 版本一致性检查、Docs/PR lint 与
git diff --check通过。 - 最新表述与 #2523 的 305.10 ms → 62.55 ms benchmark 一致。
91bbc90 to
d013ba4
Compare
Signed-off-by: Yuanhong Peng <yummypeng@linux.alibaba.com>
d013ba4 to
3e6190b
Compare
Summary
Changes since v0.4.2
Features
Bug Fixes
Test plan
cargo fmt --check && cargo clippy -D warnings && cargo testpass insrc/ws-ckpt/src/rpmbuild -bb ws-ckpt.specsucceeds🤖 Generated with Claude Code