fix(react-instantsearch-core): Preserve helper state during freeze/unfreeze operations#6629
Draft
dmitry-blackwave wants to merge 3 commits intoalgolia:masterfrom
Conversation
dmitry-blackwave
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 83a5000:
|
Contributor
|
Thanks for your PR. In which situation do you see freeze/unfreeze operations? with an added test to explain the scenario this could be a good fix |
Author
|
Yes, I'm planning to add missing stuff to the description this weekend |
Haroenv
force-pushed
the
master
branch
3 times, most recently
from
c1fa2e8 to
9af869e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where helper state was not properly maintained during freeze/unfreeze operations
Result
no blank screen when unfreeze anymore.