Simplify getXmlString() to use ByteArrayOutputStream.toString()#368
Open
michal-morzywolek wants to merge 2 commits intomainfrom
Open
Simplify getXmlString() to use ByteArrayOutputStream.toString()#368michal-morzywolek wants to merge 2 commits intomainfrom
michal-morzywolek wants to merge 2 commits intomainfrom
Conversation
Replace new String(toByteArray()) with toString() for cleaner code. Both use the platform's default charset; no functional change. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace new String(toByteArray()) with toString() for cleaner code. Both use the platform's default charset; no functional change. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
Hi @michalradziwon, my first claude commit. super basic. please approve |
|
BrunoSMonteiro74
approved these changes
Feb 4, 2026
Contributor
BrunoSMonteiro74
left a comment
BrunoSMonteiro74
left a comment
There was a problem hiding this comment.
Small change improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new String(toByteArray())withtoString()inDummyXmlOutputStreamProvidermorf-core(test) andmorf-testsupport(main)Test plan
mvn test)🤖 Generated with Claude Code