test(cloudflare/containers): deploy the #1321 container-binding shape - #1325
Merged
Merged
Conversation
Contributor
|
Install the packages built from this commit: Alchemyalchemy bun add https://pkg.ing/alchemy/e94e7f7@alchemy.run/better-auth bun add https://pkg.ing/@alchemy.run/better-auth/e94e7f7@alchemy.run/cloudflare-runtime bun add https://pkg.ing/@alchemy.run/cloudflare-runtime/e94e7f7@alchemy.run/frontend-frameworks bun add https://pkg.ing/@alchemy.run/frontend-frameworks/e94e7f7@alchemy.run/node-utils bun add https://pkg.ing/@alchemy.run/node-utils/e94e7f7@alchemy.run/pr-package bun add https://pkg.ing/@alchemy.run/pr-package/e94e7f7@alchemy.run/floci bun add https://pkg.ing/@alchemy.run/floci/e94e7f7Distilled@distilled.cloud/core bun add https://pkg.ing/@distilled.cloud/core/dd2a322@distilled.cloud/aws bun add https://pkg.ing/@distilled.cloud/aws/dd2a322@distilled.cloud/axiom bun add https://pkg.ing/@distilled.cloud/axiom/dd2a322@distilled.cloud/cloudflare bun add https://pkg.ing/@distilled.cloud/cloudflare/dd2a322@distilled.cloud/hetzner bun add https://pkg.ing/@distilled.cloud/hetzner/dd2a322@distilled.cloud/neon bun add https://pkg.ing/@distilled.cloud/neon/dd2a322@distilled.cloud/planetscale bun add https://pkg.ing/@distilled.cloud/planetscale/dd2a322 |
Issue #1321 reported the #953 symptom — `getContainer(env.X)` dying with `idFromName is not a function` — for a Container bound on an async Worker's `env` in the shape the Containers guide documents: `className` omitted, so the env key, the Container's logical id and the DO class share one name. The fix landed in #1271; this pins that exact shape with a deployed fixture, driven over HTTP in both dev and live. Without #1271 the deployed Worker reports env.Probe as `{"_id":"Effect","op":"alchemy/EffectClass"}`; with it, a namespace that round-trips Worker -> DO class -> container. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
sam-goodwin
force-pushed
the
claude/unit-test-fixture-repro-2a3aea
branch
from
August 23, 2026 10:27
bb9ab05 to
e94e7f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1321
#1321 is the #953 symptom again —
getContainer(env.X, …)dying withidFromName is not a functionfor a Container bound on an async Worker'senv. The fix landed in #1271 (merged after the issue was filed; the reporter was on beta.74). This PR changes no behaviour; it pins the exact reported shape with a deployed fixture.The existing
fixtures/asynccase names a class that differs from the env key. WithclassNameomitted there is nothing left to tell the Worker'sdurable_object_namespacebinding and itscontainersmetadata apart, so this is the shape that collapsed under onesidand lost the namespace binding.Deployed in the dev/live matrix of
Container.test.tsand driven over HTTP:/bindingassertsenv.Probeis a namespace,/helloround-trips Worker → DO class → container. Reverting the #1271 hunk fails it on a real deploy with the reporter's exact payload:Not addressed
The issue's "Related friction" note — a deploy silently adopting the Worker as external with
env: {}whenmaintransitively imports a module Node can't load — is not reproduced. Nothing importsmainunder Node at plan time, and recovery-by-renaming points at a state/adoption interaction; it needs the reporter's state export to chase.