Fix/argument robustness #183
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arguments are passed to the click callback (from click code) in lowercase. It's necessary we treat all arguments as lowercase also to prevent errors interfacing with this.
Prevent issues rising from args being treated as ints They are later `strip`ed which would cause a breaking bug
The change so that argument names are downcased in order to match their values returned as from click (the commit before last) moved the problem such that there would be miss-match between the argument names stored by the system and those specified in the tool's cmd. This resulted in arguments not being used. This commit searches through a tools cmd on execution to fix this miss-match by replacing all instances with downcased versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #179
generally makes tool arguments more robust
Stops breakage if an argument is just an integer
Stops breakage if argument contains any uppercase characters and handles this as well as possible. All argument names are treated as lowercase, so input, INPUT and InPuT are one and the same.
This is the best possible outcome as we loose info when a command's callback is called by
clickcode; the dict that returns is downcased.https://github.com/alces-software/adminware/blob/develop/src/appliance_cli/command_generation.py#L136