nix develop-based fast path in CI - #230
Draft
katrinafyi wants to merge 23 commits into
Draft
Conversation
having separate `out` and `dev` seems to cause problems.......
and `nix` unconditionally, just to make sure that they work. it would have to look something like: - `nix build` - `opam exec dune` - `nix develop --command dune build` i guess that `opam exec dune` should be the only one that is blocking? but then the other ones are only useful to get fast negative feedback earlier? and the automerge is still stuck behind the slow one. maybe only run `opam exec` in main?
ocaml5.4.1-sherlodoc> File "sherlodoc/test/dune", lines 1-12, characters 0-227: ocaml5.4.1-sherlodoc> 1 | (rule ocaml5.4.1-sherlodoc> 2 | (target ocaml5.4.1-sherlodoc> 3 | (dir docs)) ocaml5.4.1-sherlodoc> .... ocaml5.4.1-sherlodoc> 10 | (run mkdir -p docs) ocaml5.4.1-sherlodoc> 11 | (run odig odoc --cache-dir=docs --no-pkg-deps tyxml) ocaml5.4.1-sherlodoc> 12 | (run rm docs/html/tyxml/_doc-dir)))) ocaml5.4.1-sherlodoc> (cd _build/default/sherlodoc/test && /nix/store/frk7ipp0rf5ja0c9bs011k8269jm46h4-ocaml5.4.1-odig-0.1.0/bin/odig odoc --cache-dir=docs --no-pkg-deps tyxml) ocaml5.4.1-sherlodoc> odig: Error: Unknown package tyxml. ocaml5.4.1-sherlodoc> (cd _build/default/sherlodoc/query/test && ./test.exe) ocaml5.4.1-sherlodoc> Testing `Query'. thingy
it gets the .changes file, then it uses that to iterate over and classify files owned by that package. the first should be able to be short-cutted by an environment variable, and the second should be able to be replaced by a simple `find`?
just missing Stdlib docs i think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i am back on the nix opam shell grind. i want it to give a fast path for ci which is less maintenance steps and less flaky than the docker image. it should still support falling back to opam install in case the nix shell is missing some packages, so that a failing nix build doesn't block CI.
i'm abandoning my approach from last week, because that approach was using opam install --fake which is "dangerous and likely to break your opam environment". the goal of that was to somehow "teach" opam about the nixpkgs ocaml packages so opam will only install the missing ones, but i think this would be very fragile and didn't get to a proof of concept stage.
instead, i think it can be something much simpler. you just use all nixpkgs ocaml packages and if that fails, then use all opam packages. it's a lot slower in the fallback case, but hopefully that should be rare enough that it doesn't matter.
future work (beyond today), will look at caching the nixpkgs packages in github actions