-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix(evaluator_storage): correct docstring on directory organization #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@kristol07 Thanks for pointing out the issue, but the it seems like it's the typo in docstrings rather than the code implementation. Considering we are developing evaluation visualization in agentscope-studio with the current directory organization, maybe just fix the wrong description in docstrings instead? |
|
@DavdGao I think the best approach depends on how you want to interpret or evaluate the results. In my situation, since there are multiple distinct testing scenarios and I want to assess my agent's stability in each one, I’m more interested in the outcomes of each repeated task within the same scenario. Therefore, grouping the results by task ID is preferable in my case, that's why I thought it's code error. On the other hand, if all the testing scenarios are of the same type, it makes more sense to group by repeat ID and review the overall results across all test scenarios, that may be the case of agentscope-studio. |
Hi @DavdGao Do you have any suggestion on the flexibility to be provided to developers? For your comment, pr is updated already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and thanks for your contribution to the agentscope library




AgentScope Version
commit: 5c3a770
I am updating the latest code in main branch.
Description
fix(evaluator_storage): correct save path ordering in FileEvaluatorStorage
In docstring, the directory structure is:
The files are organized in a directory structure: - save_dir/ - evaluation_result.json - evaluation_meta.json - {task_id}/ - {repeat_id}/ - solution.json - evaluation/ - {metric_name}.jsonBut the implementation doesn't follow this structure.
Checklist
Please check the following items before code is ready to be reviewed.
pre-commit run --all-filescommand