Repository navigation
ci: let every Changelog guard run finish, so none is left cancelled - #642
Merged
Merged
Conversation
Dependabot labels a pull request as it opens it, so one pull request starts several guard runs at once, and cancel-in-progress cancelled all but one. A cancelled run kept the required Changelog guard check from passing and held the merge until the cancelled runs were re-run. Each run reads only its own event and finishes in seconds, so the concurrency group goes and every run finishes. A job-level if that skips label events other than changelog would also avoid the extra runs, but a skipped job passes a required check, so an unrelated label added to a pull request that edits CHANGELOG.md would clear its failure. Signed-off-by: Louie Lu <48041247+lywinged@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UtTRZHH7SXtpEikWace636
rajnisht7
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Removes the
concurrencygroup from.github/workflows/changelog-guard.ymland leaves a comment in its place saying why there is none.Dependabot labels a pull request as it opens it, so one pull request starts three guard runs within a second, one for
openedand one for eachlabeled, andcancel-in-progresscancelled all but one. On #639 that left cancelled runs beside the one that passed, and the pull request stayed blocked with an approval on its head and every other required check green. I re-ran the two cancelled runs at 03:02 UTC on 28 October and changed nothing else; auto-merge merged it at 03:04:41Z. #641's first head had the same three runs, two of them cancelled. #636 and #637, whose last push was a singlesynchronize, had one run each and merged.Each run reads only its own event's base, head and labels and finishes in seconds, so letting all of them finish costs nothing.
Not done instead: a job-level
ifthat skips label events other thanchangelog. A skipped job reports success and does not block a merge even when it is a required check, so on a pull request that editsCHANGELOG.mdany unrelated label would clear the guard's failure. The comment in the workflow says this too, so the group is not put back and theifis not reached for.Type of change
None of these: a CI workflow only.
Spec section
None.
Tests for a fix
Not a code or schema fix. The behaviour it changes is the one shown on #639 above. actionlint 1.7.12, the version the Workflow lint job pins, is clean on every workflow with this change, as it is on
main.Changelog entry
None: a CI workflow change, with nothing in the specification or the package changed.
Checklist
git commit -s)<!-- CHANGED: #NNN: description -->in spec textGenerated by Claude Code