[CLIENT-4834] Fix memory error when shared memory is enabled and server version is read before sending user agent string#1067
Conversation
…nitialized read when testing shm locally
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1067 +/- ##
=======================================
Coverage 84.44% 84.44%
=======================================
Files 99 99
Lines 14062 14062
=======================================
Hits 11874 11874
Misses 2188 2188 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Resolved by deleting the existing shared memory segment locally. But when rerunning without deleting the shared memory segment, a crash occurs.
|
…ll_socket -> FD_SET() where fd is -1.
… one in the docstring for as_config doesn't match the implementation
…tops the test from crashing, remove this default shm key so we don't need to manually update it if the c client updates the default one (e.g in this PR)
…000000 stops the test from crashing, remove this default shm key so we don't need to manually update it if the c client updates the default one (e.g in this PR)" This reverts commit aec7da9.
…ent instance if they use the same host seeds
…-error-from-user-agent-and-shared-memory
…ing the shmem is necessary to fix the crash.
… as an empty string arg if it is empty.
…-error-from-user-agent-and-shared-memory
|
I see a new "definitely lost" memory leak in this branch: Valgrind run with only the C client changes in this branch. The tests here are the same as in A memory leak occurs similar to the one above: Valgrind run in EDIT: I saw this memory leak in |
…'s stack trace isn't being truncated. Somehow when --num-callers isn't set (i.e the default 12 is used), there are other stack traces that have more than 12 lines.
…-error-from-user-agent-and-shared-memory
…und" This reverts commit a1da36b.
…-error-from-user-agent-and-shared-memory
Testing
b957531 shows that a crash occurs.
8bba73b (the following commit) shows that the crash is fixed by the c client.
Out of scope