Merged
Conversation
Member
Author
|
@akelbert No need to look at the code, but check my notes in the PR description, and maybe look at the expected output in exportsrv/tests/unittests/stubdata/cslTest.py |
ehenneken
reviewed
Jan 20, 2026
| 'agu': u'Aharon, P.. (2005). Catastrophic flood outbursts in mid-continent left imprints in the Gulf of Mexico. <i>Geo-marine Letters</i>. https://doi.org/10.1007/s00367-005-0006-y\n', | ||
| 'gsa': u'Aharon, P., 2005, Catastrophic flood outbursts in mid-continent left imprints in the Gulf of Mexico: Geo-Marine Letters,, doi:10.1007/s00367-005-0006-y.\n', | ||
| 'ams': u'Aharon, P., 2005: Catastrophic flood outbursts in mid-continent left imprints in the Gulf of Mexico https://doi.org/10.1007/s00367-005-0006-y.\n', | ||
| 'ams': u'Aharon, P., 2005: Catastrophic flood outbursts in mid-continent left imprints in the Gulf of Mexico <i>Geo-Marine Letters</i>, https://doi.org/10.1007/s00367-005-0006-y.\n', |
Member
There was a problem hiding this comment.
Looking at the AGU style guide (https://www.agu.org/publications/authors/journals/grammar-style-guide) under "Reference list" I think the AGU format should have just one period after the author's initial:
Aharon, P. (2005). etc etc
ehenneken
reviewed
Jan 20, 2026
Member
ehenneken
left a comment
ehenneken
left a comment
There was a problem hiding this comment.
Just one small comment/question
ehenneken
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix issues reported https://adsabs.atlassian.net/browse/MIC-91:
form=shortin the CSL - we don't have a short form, so the journal name was omitted altogetherAlso, fixed some broken/incomplete unittests.