Skip to content

[SR] Offer hero#5969

Merged
robert-bogos merged 21 commits into
site-redesign-foundationfrom
192882
May 28, 2026
Merged

[SR] Offer hero#5969
robert-bogos merged 21 commits into
site-redesign-foundationfrom
192882

Conversation

@robert-bogos
Copy link
Copy Markdown
Contributor

@robert-bogos robert-bogos commented May 22, 2026

@robert-bogos robert-bogos requested a review from a team May 22, 2026 16:41
@robert-bogos robert-bogos self-assigned this May 22, 2026
@aem-code-sync
Copy link
Copy Markdown
Contributor

aem-code-sync Bot commented May 22, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

Comment thread libs/mep/ace1205/offer-hero/offer-hero.css Outdated
Comment thread libs/mep/ace1205/offer-hero/offer-hero.css Outdated
Comment thread libs/mep/ace1205/offer-hero/offer-hero.css
Comment thread libs/mep/ace1205/offer-hero/offer-hero.css
Comment thread libs/mep/ace1205/offer-hero/offer-hero.js
Comment thread libs/mep/ace1205/offer-hero/offer-hero.js
Comment thread libs/mep/ace1205/offer-hero/offer-hero.js
Comment thread libs/mep/ace1205/offer-hero/offer-hero.js
Comment thread libs/mep/ace1205/offer-hero/offer-hero.js
Comment thread libs/mep/ace1205/offer-hero/offer-hero.css Outdated
Comment thread libs/mep/ace1205/offer-hero/offer-hero.css
Comment thread libs/mep/ace1205/offer-hero/offer-hero.css
Comment thread libs/utils/utils.js Outdated
Comment thread libs/mep/ace1205/offer-hero/offer-hero.js Outdated
Comment thread libs/mep/ace1205/offer-hero/offer-hero.js Outdated
Comment thread libs/mep/ace1205/offer-hero/offer-hero.js
@zagi25
Copy link
Copy Markdown
Contributor

zagi25 commented May 26, 2026

I noticed that Lear more chevron is smaller than the font size
Screenshot 2026-05-26 at 11 18 05

Also, header that fades in, at the beginning of the animation, overlaps cards (if this is intended, please ignore)
Screenshot 2026-05-26 at 11 29 42

@robert-bogos
Copy link
Copy Markdown
Contributor Author

I noticed that Lear more chevron is smaller than the font size Screenshot 2026-05-26 at 11 18 05

Also, header that fades in, at the beginning of the animation, overlaps cards (if this is intended, please ignore) Screenshot 2026-05-26 at 11 29 42

The header overlapping thing is expected. Is because of the figma spec spacing.

Good catch on the "Learn more" chevron. Adjusted to match the font size 👍

@robert-bogos robert-bogos requested a review from zagi25 May 26, 2026 12:12
Comment thread libs/mep/ace1205/offer-hero/offer-hero.js Outdated
Comment thread libs/mep/ace1205/offer-hero/offer-hero.js Outdated
Comment thread libs/mep/ace1205/offer-hero/offer-hero.js Outdated
Comment thread libs/mep/ace1205/offer-hero/offer-hero.js Outdated
Comment thread libs/mep/ace1205/offer-hero/offer-hero.js Outdated
Copy link
Copy Markdown
Contributor

@overmyheadandbody overmyheadandbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure I see the content difference between mobile and tablet. I'm worried that this introduces two identical h1 tags on the page - view-source:https://main--da-dc--adobecom.aem.page/dc-shared/fragments/tests/2026/q2/ace1205/fragments/ace1205-offer.plain.html. An alternative might be needed, maybe similar to the router-marquee, where we ended up using the visually-hidden block to set the h1

Comment thread libs/mep/ace1205/offer-hero/offer-hero.css Outdated
Comment thread libs/mep/ace1205/offer-hero/offer-hero.css
Comment thread libs/mep/ace1205/offer-hero/offer-hero.css Outdated
Comment thread libs/mep/ace1205/offer-hero/offer-hero.js
@robert-bogos
Copy link
Copy Markdown
Contributor Author

I'm not quite sure I see the content difference between mobile and tablet. I'm worried that this introduces two identical h1 tags on the page - view-source:https://main--da-dc--adobecom.aem.page/dc-shared/fragments/tests/2026/q2/ace1205/fragments/ace1205-offer.plain.html. An alternative might be needed, maybe similar to the router-marquee, where we ended up using the visually-hidden block to set the h1

The video assets are different, is currently like that just to showcase some asset issues to design

Copy link
Copy Markdown
Contributor

@overmyheadandbody overmyheadandbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@robert-bogos robert-bogos merged commit 901baa9 into site-redesign-foundation May 28, 2026
9 checks passed
@robert-bogos robert-bogos deleted the 192882 branch May 28, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants