[SR] - [MWPW-192883] - Rich Content Hero Jump Variant#5932
Open
DKos95 wants to merge 5 commits into
Open
Conversation
…oor animation Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
DKos95
requested review from
ivanvatadobe,
narcis-radu,
overmyheadandbody,
rgclayton,
robert-bogos and
zagi25
Contributor
DKos95
changed the title
DKos95
changed the title
|
|
||
| .title-2, | ||
| .eyebrow { | ||
| max-width: 656px; |
Contributor
There was a problem hiding this comment.
Is this meant to be fixed or does it map to a specific number of columns?
Contributor
Author
There was a problem hiding this comment.
Not sure, what do you think?
| Viewport | Content width | Max-width | Approx columns |
|---|---|---|---|
| 768px+ | 768 − 64 = 704px | 530px | 530/704 ≈ 9/12 |
| 1024px+ | 1024 − 80 = 944px | 656px | 656/944 ≈ 8.3/12 |
| 1440px+ | 1440 − 80 = 1360px | 656px | 656/1360 ≈ 5.8/12 |
Comment on lines
+190
to
+194
| background: linear-gradient(180deg, rgba(0, 0, 0, 0.8) 0%, rgba(0, 0, 0, 0) 39%, rgba(0, 0, 0, 0) 74%, rgba(0, 0, 0, 0.8) 100%); | ||
| } | ||
|
|
||
| .section:not(.has-background):has(.rich-content.jump-link.hero) { | ||
| background: linear-gradient(180deg, rgba(0, 0, 0, 0.8) 0%, rgba(0, 0, 0, 0) 39%, rgba(0, 0, 0, 0) 74%, rgba(0, 0, 0, 0.8) 100%), var(--s2a-color-background-default); |
Contributor
There was a problem hiding this comment.
Having specific colors in code might not be a good strategy for the long term. Can authoring be leveraged in any way here?
Contributor
Author
There was a problem hiding this comment.
We can but this is just to override the wave 1 linear background being applied also via code, if we changed it here it would make sense to change it for the wave 1 code and make it authorable, not sure if we should invest time into that currently, but I do agree we should do it at one point.
narcis-radu
reviewed
May 19, 2026
…nto rich-content-hero
rgclayton
reviewed
May 20, 2026
| animation-composition: replace, add; | ||
| } | ||
|
|
||
| @keyframes dg-top-door { |
Contributor
There was a problem hiding this comment.
dg = double garage door?
rgclayton
approved these changes
May 20, 2026
zagi25
reviewed
May 21, 2026
|
|
||
| picture, | ||
| img { | ||
| width: 24px; |
Contributor
There was a problem hiding this comment.
here we should be able to use tokens
| &::after { | ||
| content: ''; | ||
| display: block; | ||
| width: 12px; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds rich-content jump-link hero variant with parallax double garage door animation
Resolves: MWPW-192883
Test URLs: