Skip to content

MWPW-189783: adds support for new card styles#5849

Open
cmiqueo wants to merge 7 commits into
stagefrom
MWPW-189783
Open

MWPW-189783: adds support for new card styles#5849
cmiqueo wants to merge 7 commits into
stagefrom
MWPW-189783

Conversation

@cmiqueo
Copy link
Copy Markdown
Contributor

@cmiqueo cmiqueo commented Apr 23, 2026

Description:
Adds new card style: Button card
Adds new Rounded Borders modifier for 1/2 and 3/4 cards styles

Dependency:
This functionality relies on this CaasUI PR to be merged:
adobecom/caas#444

Button card:
image

Rounded corners variant:
image

Resolves:
https://jira.corp.adobe.com/browse/MWPW-189783

Additional updates:

  • Alphabetizes Card Sttle dropdown
  • Renames Surce from "Hawks" to "Creative Cloud (Hawks)"
  • Adds new checkbox under UI tab for "Use Rounded Corners"
  • Adds unit-tests for:
    • Use Rounded Corners
    • Editorial Open Variant
    • sortLocalFirst
    • sortLocalLast
    • Add current page UUID from excludeIds

Test URLs:

@aem-code-sync
Copy link
Copy Markdown
Contributor

aem-code-sync Bot commented Apr 23, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@cmiqueo cmiqueo changed the title Mwpw 189783 MWPW-189783: adds support for new card styles Apr 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@github-actions
Copy link
Copy Markdown
Contributor

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions Bot added the Stale label Apr 30, 2026
@cmiqueo cmiqueo requested review from sanrai, sheridansunier and shkhan91 and removed request for sanrai May 4, 2026 17:43
@github-actions github-actions Bot removed the Stale label May 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@sheridansunier
Copy link
Copy Markdown
Contributor

A few minor items to address before merging:

  1. Trailing ... on card style labels1/2 Card..., Blade Card..., Editorial Card... look like WIP artifacts. Other entries don't have them. Please clean up before merge.

  2. [new] suffix on Use Rounded Corners label"Use Rounded Corners [new]" is informal UI copy. Fine for now but should be tracked for removal once the feature is established.

  3. Dependency on caas#444 — the PR description calls this out, but please confirm adobecom/caas#444 is merged before this goes to stage, otherwise the Button card style will appear in the configurator with no rendering backing.

  4. secondaryCta URL redirect is untested — the cta2style === 'button' ? p.cta1url : p.cta2url logic in send-utils.js is the most non-obvious behavior in the diff and has no unit test. Worth adding a regression test for this case.

None of these are blockers for approval but items 1 and 3 should be resolved before the stage merge.

Copy link
Copy Markdown
Contributor

@sheridansunier sheridansunier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good feature addition with solid test coverage for the new options. Left a comment with a few items to clean up before the stage merge — mainly the trailing '...' on card style labels and confirming caas#444 is landed. Nothing blocking approval. Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants