Skip to content

MWPW-187017: Correctly decorate double tag CTAs#5820

Open
zagi25 wants to merge 2 commits into
stagefrom
mwpw-187017-double-tag-cta
Open

MWPW-187017: Correctly decorate double tag CTAs#5820
zagi25 wants to merge 2 commits into
stagefrom
mwpw-187017-double-tag-cta

Conversation

@zagi25
Copy link
Copy Markdown
Contributor

@zagi25 zagi25 commented Apr 16, 2026

Issue: If CTA link is both bold and italic, on newly previewed pages tag that is returned is:
<em><strong><a href="https://www.adobe.com/products/special-offers.html">Découvrir nos offres spéciales</a></strong></em>
Current logic, treats this only as strong resulting in blue button

  • Check if strong tag has em parent

Example:

  • Old DC page: <strong><em><a href="">More tutorials</a></em></strong> -> outline btn
  • Imported DA DC page: <em><strong><a href="">More tutorials</a></strong></em> -> blue btn

Resolves: MWPW-187017

Test URLs:

DC URLs:

BACOM URLs:

CC URLs:

@zagi25 zagi25 requested a review from a team April 16, 2026 06:54
@zagi25 zagi25 added the high-impact Any PR that may affect consumers label Apr 16, 2026
@aem-code-sync
Copy link
Copy Markdown
Contributor

aem-code-sync Bot commented Apr 16, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@narcis-radu
Copy link
Copy Markdown
Contributor

narcis-radu commented Apr 24, 2026

@zagi25 I am concerned that the privacy banner CTAs have been updated as well, is that connected or just random?
Screenshot 2026-04-24 at 15 42 42

@github-actions
Copy link
Copy Markdown
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@NadiiaSokolova NadiiaSokolova self-assigned this Apr 29, 2026
@zagi25
Copy link
Copy Markdown
Contributor Author

zagi25 commented Apr 29, 2026

@narcis-radu it looks like it is on their side, blue buttons appear on feature branch (didn't notice on stage/main)
https://firefox-animations--milo--adobecom.aem.page/?martech=off
Screenshot 2026-04-29 at 15 14 51
Screenshot 2026-04-29 at 15 15 03

@github-actions
Copy link
Copy Markdown
Contributor

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions
Copy link
Copy Markdown
Contributor

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

high-impact Any PR that may affect consumers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants