[MWPW-190551] Preflight integration with C2 blocks by skholkhojaev · Pull Request #5737 · adobecom/milo

skholkhojaev · 2026-03-31T15:09:59Z

This PR makes it so that utils.js would make an exception for prelfight when running on a page that has C2 blocks.
in addition it adds some css and code to help it be more compatible with the C2 blocks

Test URLs:

aem-code-sync · 2026-03-31T15:10:03Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

Re-sync branch

Commits

6833229 ✅ (latest)
cbc8ab9 ✅
3e2447b ✅
b66132d ✅
3b7a666 ✅
a3d5976 ✅
85eacdf ✅
36f8f76 ✅
e946e24 ✅

robert-bogos · 2026-04-01T13:31:16Z

      asset.addEventListener(event, resolve, { once: true });
-    })));
+    })),
+    new Promise((resolve) => { setTimeout(resolve, 5000); }),


Why the 5s timeout? 🤔

so i've been testing the preflight in multiple different pages and in one of the draft pages that you gave me (https://main--milo--adobecom.aem.page/drafts/rbogos/c2/multimedia-marquee-21) the Assets never loaded so i figured that it might becuase the element never fired either "loadedmetaddata" or "error" so i added a 5 seconds timeout to fix any race conditions

if 5 seconds is too long i could reduce it to 2 or i could fix the block to make sure that it listens to the correct value to fire back only "loadedmetaddata" or "error"

A specific timeout can leave room for unwanted behaviour. I would try to use something like the PerformanceObserver and wait for network calls to calm down. Something along the lines of: when no networks calls are done in the past 3s, do something

narcis-radu · 2026-04-02T06:23:08Z

  const isAutoBlock = AUTO_BLOCKS.some((autoBlock) => autoBlock[name]);

-  if (isC2Page && isC1Block && !isC2Block && !isAutoBlock) return { name, isInvalid: true };
+  const isPageAgnostic = name === 'preflight';


can we add to an array; we might have other tools that are basically page agnostic.

Yes! Done 👍

narcis-radu · 2026-04-02T06:27:45Z

@@ -4,6 +4,18 @@ import { displayPreflightVisuals } from '../visual-metadata.js';



I see https://preflight-siteredesign-integration--milo--adobecom.aem.live/libs/c2/blocks/global-footer/adobe-logo-full.svg is showing that it has never been previewed or published, but accessing a file I get 200. Helix status shows 404.

JasonHowellSlavin · 2026-04-03T21:59:03Z

+  const PAGE_AGNOSTIC_BLOCKS = ['preflight'];
+  const isPageAgnostic = PAGE_AGNOSTIC_BLOCKS.includes(name);


super nit, but why not lump these const declarations with the rest up above

robert-bogos

Looks good 👍

github-actions · 2026-04-17T02:52:21Z

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

narcis-radu · 2026-04-24T12:44:35Z

@biljana-cvijanovic - can you provide feedback in the PR? Looks like you had some concerns in JIRA

biljana-cvijanovic · 2026-04-26T18:23:53Z

After testing, I identified several issues and added them as comments in the Jira ticket https://jira.corp.adobe.com/browse/MWPW-190551 . The issues were discussed with @robert-bogos in case he had time to review them while Sino was away.
Since there have been no updates, I guess @skholkhojaev can continue and update the PR. The ticket will be reassigned to him.

skholkhojaev · 2026-04-27T07:07:06Z

got it, thankyou @biljana-cvijanovic !

github-actions · 2026-04-28T03:36:46Z

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

github-actions · 2026-05-06T03:30:24Z

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

skholkhojaev · 2026-05-13T08:54:48Z

i've added two new commits since last reivew maybe it would be a good to have someone give a quick review before the QA approval @robert-bogos @mokimo

biljana-cvijanovic · 2026-05-19T15:49:07Z

Validated. Test details https://jira.corp.adobe.com/browse/MWPW-190551

…s in the future

fixed alt text and logo appearing double, exclude /libs/ from the source path

skholkhojaev requested a review from robert-bogos March 31, 2026 15:09

skholkhojaev requested a review from a team as a code owner March 31, 2026 15:10

robert-bogos reviewed Apr 1, 2026

View reviewed changes

Comment thread libs/utils/utils.js Outdated

skholkhojaev requested a review from robert-bogos April 1, 2026 14:29

aem-code-sync Bot temporarily deployed to preflight-siteredesign-integration April 1, 2026 16:18 Inactive

narcis-radu reviewed Apr 2, 2026

View reviewed changes

aem-code-sync Bot temporarily deployed to preflight-siteredesign-integration April 2, 2026 07:35 Inactive

skholkhojaev requested review from mokimo and narcis-radu April 2, 2026 08:19

narcis-radu approved these changes Apr 2, 2026

View reviewed changes

Base automatically changed from site-redesign-foundation to main April 2, 2026 12:50

JasonHowellSlavin approved these changes Apr 3, 2026

View reviewed changes

narcis-radu changed the base branch from main to site-redesign-foundation April 9, 2026 11:09

robert-bogos approved these changes Apr 9, 2026

View reviewed changes

github-actions Bot added the Stale label Apr 17, 2026

robert-bogos removed the Stale label Apr 20, 2026

Base automatically changed from site-redesign-foundation to stage April 27, 2026 10:11

github-actions Bot added the Stale label May 6, 2026

skholkhojaev changed the base branch from stage to site-redesign-foundation May 7, 2026 12:40

github-actions Bot removed the Stale label May 8, 2026

aem-code-sync Bot temporarily deployed to preflight-siteredesign-integration May 13, 2026 08:52 Inactive

biljana-cvijanovic approved these changes May 19, 2026

View reviewed changes

aem-code-sync Bot temporarily deployed to preflight-siteredesign-integration May 20, 2026 12:16 Inactive

narcis-radu changed the base branch from site-redesign-foundation to stage May 20, 2026 15:59

narcis-radu changed the base branch from stage to site-redesign-foundation May 20, 2026 16:00

skholkhojaev changed the base branch from site-redesign-foundation to stage May 20, 2026 16:14

skholkhojaev force-pushed the preflight-siteredesign-integration branch from a05cfe3 to f25149b Compare May 20, 2026 16:37

skholkhojaev added 9 commits May 20, 2026 18:38

added exception to utils.js to call preflight from C1 block

e946e24

fixed assets.js loading forever + fixed prelight modal close button

36f8f76

replaced the hardcoded timeout with NetworkIdle

85eacdf

fixed linting

a3d5976

changed the hardcoded Agnostic page into an Array for potential block…

3b7a666

…s in the future

implemented issues found by the QA,

b66132d

fixed alt text and logo appearing double, exclude /libs/ from the source path

changed waitForNetworkIdle to actually detect idle and bound its wait

3e2447b

fix preflight logo position shift from alt-text label

cbc8ab9

fix preflight Martech styling consistency with c1

6833229

skholkhojaev force-pushed the preflight-siteredesign-integration branch from f25149b to 6833229 Compare May 20, 2026 16:41

aem-code-sync Bot deployed to preflight-siteredesign-integration May 20, 2026 16:41 View deployment

biljana-cvijanovic added the Ready for Stage label May 20, 2026

milo-pr-merge Bot merged commit b811266 into stage May 20, 2026
19 of 20 checks passed

milo-pr-merge Bot deleted the preflight-siteredesign-integration branch May 20, 2026 21:49

github-actions Bot mentioned this pull request May 20, 2026

[Release] Stage to Main #5944

Merged

		@@ -4,6 +4,18 @@ import { displayPreflightVisuals } from '../visual-metadata.js';

		const PAGE_AGNOSTIC_BLOCKS = ['preflight'];
		const isPageAgnostic = PAGE_AGNOSTIC_BLOCKS.includes(name);

Conversation

skholkhojaev commented Mar 31, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aem-code-sync Bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robert-bogos Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

skholkhojaev Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

robert-bogos Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

narcis-radu Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

skholkhojaev Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

narcis-radu Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

JasonHowellSlavin Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

robert-bogos left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 17, 2026

Uh oh!

narcis-radu commented Apr 24, 2026

Uh oh!

biljana-cvijanovic commented Apr 26, 2026

Uh oh!

skholkhojaev commented Apr 27, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

github-actions Bot commented May 6, 2026

Uh oh!

skholkhojaev commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

biljana-cvijanovic commented May 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

skholkhojaev commented Mar 31, 2026 •

edited by github-actions Bot

Loading

aem-code-sync Bot commented Mar 31, 2026 •

edited

Loading

skholkhojaev commented May 13, 2026 •

edited

Loading