Skip to content

[CCEX-248841] Enable Open in express export option for safari desktop only#783

Draft
kalyanrevuru wants to merge 10 commits into
adobecom:stagefrom
kalyanrevuru:frictionless-safari
Draft

[CCEX-248841] Enable Open in express export option for safari desktop only#783
kalyanrevuru wants to merge 10 commits into
adobecom:stagefrom
kalyanrevuru:frictionless-safari

Conversation

@kalyanrevuru
Copy link
Copy Markdown
Collaborator

Summary

https://jira.corp.adobe.com/browse/CCEX-248841

This PR enables "Open in adobe express" CTA for safari desktop only. iOS/iPad will still not see "Open in adobe express", as LOE is not enabled for iOS/iPad.


Jira Ticket

Resolves: CCEX-248841


Test URLs

Env URL
Before https://main--express-milo--adobecom.aem.page/express/
After https://frictionless-safari--express-milo--kalyanrevuru.aem.page/express/?martech=off

Verification Steps

  • Steps to reproduce the issue or view the new feature.
  • What to expect before and after the change.

Potential Regressions


Additional Notes

(If applicable) Add context, related PRs, or known issues here.

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Nov 12, 2025

Page Scores Audits
📱 /express/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
🖥️ /express/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
📱 /express/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
🖥️ /express/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS

@kalyanrevuru kalyanrevuru reopened this Nov 12, 2025
@kalyanrevuru kalyanrevuru changed the base branch from frictionless-safari to stage November 12, 2025 04:23
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 37.83784% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.62%. Comparing base (e80982c) to head (2fd564f).

Files with missing lines Patch % Lines
express/code/scripts/utils/frictionless-utils.js 37.83% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #783      +/-   ##
==========================================
- Coverage   70.86%   70.62%   -0.25%     
==========================================
  Files         109      108       -1     
  Lines       25341    25270      -71     
==========================================
- Hits        17959    17846     -113     
- Misses       7382     7424      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kalyanrevuru kalyanrevuru marked this pull request as ready for review November 18, 2025 06:46
@kalyanrevuru kalyanrevuru added the Ready for Review Ready for peer review. label Nov 18, 2025
@kalyanrevuru kalyanrevuru marked this pull request as draft November 21, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready for Review Ready for peer review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants