[Doodlebug] New aside-carousel block#59
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
|
Hello @JingleH , |
|
Thankyou @JingleH for the fix on image peek view in left , when verified with video in ipad do not see it working as expected, can you please take a look |
Hi @spadmasa , part of the request was to make it authorable, so there are 2 links: one with no-cilp-left variant, and this will not hide the left card; the other one is standard default, and it will hide the left card. If we want to verify the hiding logic, can you help verify on https://doodlebug-aside-carousel--da-cc--adobecom.aem.live/drafts/jingle/image-upscaler-aside-carousel? Thanks! |
|
Thankyou @JingleH verified with authoring change , seen working as expected https://doodlebug-aside-carousel--da-cc--adobecom.aem.page/drafts/souj/doodle-audio/image-upscaler-aside-carousel-no-clip-left |
|
|
||
| const { setLibs } = await import('../../../creativecloud/scripts/utils.js'); | ||
| setLibs('https://milo.adobe.com/libs'); | ||
| const { default: init, handleImageLoad } = await import('../../../creativecloud/blocks/aside-carousel/aside-carousel.js'); |
There was a problem hiding this comment.
I don't see handleImageLoad getting defined or exported from aside-carousel.js. Could you please re-check?
There was a problem hiding this comment.
Yes @nkthakur48 it's dead code copied from milo's aside and not cleaned up. I've removed it and also added case for the newly added no-clip-left variant. Good catch!




Currently on Doodlebug pages, MEP is leveraged to swap out aside blocks with a section using carousel and editorial-cards. It could be better UX to use a responsive block (aside on desktop, carousel on tablet/mobile), and it would also remove the dependency on MEP, allowing automation of pages to be more streamlined.
This is a brand new block so should have no regression risk. No Figma yet as we are trying to proceed quickly. This is a best-effort attempt at combining multiple blocks and retaining doodlebug.css theme override under the time constraint.
Test URLs: