Skip to content

#450: allow successful trados translations with skipped and canceled … #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrischrischris merged 2 commits into from
May 21, 2026
Merged

#450: allow successful trados translations with skipped and canceled … #451

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef4ab76
#450: allow successful trados translations with skipped and canceled …
andreas-haller May 20, 2026
64ecf91
Merge branch 'main' into 450-trados-skipped
chrischrischris May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions nx/blocks/loc/connectors/trados/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,9 +281,7 @@ export async function sendAllLanguages({

export function getSourceFileStatus(tasks) {
// If source file tasks fail, all langs fail
const sourceTasks = tasks.filter((task) => (
['scan', 'convert', 'copy-to-target'].includes(task.taskType?.key)
));
const sourceTasks = tasks.filter((task) => task.input?.type === 'sourceFile');
if (!sourceTasks.length) return null;
if (sourceTasks.some((t) => t.status === 'failed')) return 'error';
if (sourceTasks.some((t) => t.status === 'canceled')) return 'canceled';
Expand All @@ -302,8 +300,6 @@ export function getLangStatus(tasks, langCode, fileCount) {
)).length;

if (langTasks.some((t) => t.status === 'failed')) return { status: 'error', translated };
if (langTasks.some((t) => t.status === 'skipped')) return { status: 'skipped', translated };
if (langTasks.some((t) => t.status === 'canceled')) return { status: 'canceled', translated };
if (translated === fileCount) return { status: 'translated', translated };

return { status: 'in progress', translated };
Expand Down
Loading