Ew shell#428
Open
hannessolo wants to merge 175 commits into
Open
Conversation
feat: basic chat ui - initial commit
* feat: chat controller initial commit * feat: chat agent connection * fix: support response streaming * feat: basic markdown rendering * feat: move minimal exports of mdast from nx to nx2 * chore: code cleanup * chore: cleanup * chore: code cleanup
… add-to-chat
Merges 6 commits from ew (move-in-outline, file-explorer, open-media-from-browse,
add-to-chat, chat-slash-menu, IMS fix). App-side files that moved to da-live
(canvas, browse, tool-panel blocks) stay deleted. Chat-side conflicts resolved:
constants gains COMMAND key, api uses DA_ADMIN with safe {} return, chat.js
deduplicates imports and uses loadSiteConfig. Fixes daFiles.js import path
(daFetch.js → api.js) and call style (positional → destructured).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
These files (nx-file-explorer, editor-utils/blocks, shared/utils/tree-nav, utils/daFiles) were new in ew and merged in automatically, but they belong in da-live — not in the da-nx shell. Equivalents already exist in da-live as ew-file-explorer, editor-utils/blocks, canvas/utils/tree-nav, and blocks/shared/daFiles. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix: browse scroll * chore: update style
# Conflicts: # nx2/blocks/browse/browse.css # nx2/blocks/browse/list/list.css # nx2/blocks/browse/list/list.js # nx2/blocks/browse/overrides.css
* feat: reusable dialog + toast * chore: review comments * test: unit tests for toast * chore: cleanup
| * governing permissions and limitations under the License. | ||
| */ | ||
|
|
||
| export { loadStyle } from '../utils/style.js'; |
Member
There was a problem hiding this comment.
I would just copy the function. I'd rather have a dupe of a function than another chained request.
| } | ||
| } | ||
|
|
||
| if (isDoc && localStorage.getItem('nx-panels')) { |
Member
There was a problem hiding this comment.
Do we really want to load the panels so late? This seems like it will cause CLS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://ew-shell--da-nx--adobe.aem.page
adobe/da-live#924