fix: prevented _EVENT_BY_DELEGATINGNODE marker from stopping actual w…#16
Open
SKreileder wants to merge 1 commit intomasterfrom
Open
Conversation
SKreileder
force-pushed
the
#2069703-UpdateableDelegatingNode-stacks-dont-handle-events-correctly
branch
from
3d03625 to
844990f
Compare
…rites to another UpdateableDelegatingNode in the hierarchy (#2069703)
SKreileder
force-pushed
the
#2069703-UpdateableDelegatingNode-stacks-dont-handle-events-correctly
branch
from
844990f to
461ded9
Compare
rH4rtinger
reviewed
Mar 31, 2026
propertly.core/src/main/java/de/adito/propertly/core/api/DelegatingNode.java
Show resolved
Hide resolved
propertly.core/src/test/java/de/adito/propertly/core/api/UpdateableDelegatingNodeTest.java
Show resolved
Hide resolved
propertly.core/src/main/java/de/adito/propertly/core/api/DelegatingNode.java
Show resolved
Hide resolved
| Assertions.assertEquals(updateableHierarchyListener.asString(), sourceHierarchyListener.asString()); | ||
| assertEquals(updateableHierarchyListener.asString(), sourceHierarchyListener.asString()); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Is any of the test cases made similar to the original error case?
Are you using the same/similar Hierarchy/Node classes for modelling those cases?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rites to another UpdateableDelegatingNode in the hierarchy (#2069703)