chore: typed flat eslint config and strict tsconfig - #27
Merged
Conversation
Replace eslint-config-oclif + Prettier with a typed flat ESLint config (typescript-eslint strictTypeChecked, @Stylistic, eslint-plugin-n, eslint-plugin-import-x), reformat the tree to match, and run lint with --max-warnings 0. Modernize tsconfig: target es2024, module/moduleResolution nodenext, lib pinned to es2024 so DOM globals stay out of a CLI, plus noUncheckedIndexedAccess, exactOptionalPropertyTypes, verbatimModuleSyntax, erasableSyntaxOnly, isolatedModules and the noUnused*/noImplicit* family. Raise engines.node to ^22 || >=24. Node 18 and 20 are past end-of-life, and >=18.0.0 was already inaccurate: open@11 needs Node 20+. Validate argv in auth login (await this.parse) — unknown flags now fail with exit code 2 instead of being silently ignored. 88 remaining violations are suppressed inline, each marked "FIXME if you see this" for a follow-up pass. The oclif manifest is unchanged against main: 73 commands with identical metadata, so no command, flag or output moved. 193 tests pass. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
gshteynardt
force-pushed
the
chore/strict-lint-and-tsconfig
branch
from
September 9, 2026 14:51
a700fef to
25aa2fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace eslint-config-oclif + Prettier with a typed flat ESLint config (typescript-eslint strictTypeChecked, @Stylistic, eslint-plugin-n, eslint-plugin-import-x), reformat the tree to match, and run lint with --max-warnings 0.
Modernize tsconfig: target es2024, module/moduleResolution nodenext, lib pinned to es2024 so DOM globals stay out of a CLI, plus noUncheckedIndexedAccess, exactOptionalPropertyTypes, verbatimModuleSyntax, erasableSyntaxOnly, isolatedModules and the noUnused*/noImplicit* family.
Raise engines.node to ^22 || >=24. Node 18 and 20 are past end-of-life, and >=18.0.0 was already inaccurate: open@11 needs Node 20+.
Validate argv in auth login (await this.parse) — unknown flags now fail with exit code 2 instead of being silently ignored.
88 remaining violations are suppressed inline, each marked "FIXME if you see this" for a follow-up pass.
The oclif manifest is unchanged against main: 73 commands with identical metadata, so no command, flag or output moved. 193 tests pass.