fix(ui): honor includeBackground for non-animated decorator backgrounds - #170
Open
kar wants to merge 1 commit into
Open
fix(ui): honor includeBackground for non-animated decorator backgrounds#170kar wants to merge 1 commit into
kar wants to merge 1 commit into
Conversation
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression
Since 4.0.0,
AdaptyUIAnimatableDecoratorModifier.bodyWithBackgroundapplies theincludeBackgroundopacity gate only in the animated-background branch; the static branch paints the decorator background unconditionally:In 3.17.x every branch was gated (
AdaptyUIDecoratorModifier, all three branches applied.opacity(includeBackground ? 1.0 : 0.0)).Visible effect
The footer is the only element rendered with
includeBackground == false(drawDecoratorBackgroundinAdaptyUIHeroContainerView/AdaptyUIFlatContainerView): its background is meant to appear only once scrollable content extends beneath the footer. With the gate lost, a translucent footer background (e.g.#000000BFin dark mode) is composited over the screen content unconditionally, visibly darkening the footer band on any paywall using one.Measured on a production paywall (legacy Paywall Builder template
basic, dark mode): footer bandrgb(57,57,57)under 3.17.2 vsrgb(14,14,14)under 4.0.2 — exactly one extra application of the#000000BFscrim over the same backdrop.Fix
Restore the gate on the static branch, matching the animated branch and the 3.x behavior. One line.