Add support for user to specify the height for the circle#6
Open
tech-tendai wants to merge 3 commits into
Open
Add support for user to specify the height for the circle#6tech-tendai wants to merge 3 commits into
tech-tendai wants to merge 3 commits into
Conversation
Add support for user to specify the height for the circle, and for example, use the result for to_lat_lon_height() as the outerboundary for the circle.
Owner
|
Thanks for your contribution! |
Made the height parameter optional (height=0.0 line 61) to avoid breaking the package for those using the current version.
Author
Thanks Adam, I committed it as fc6e483 |
Owner
|
Hi, apologies for the late reply. Could you please help me understand the usecase? Can it be exported to a KML? |
Author
|
Yes Adam,
As picture is worth many words, please see attached picture.
[image: image.png]
Regards,
Tendai.
…On Wed, Mar 31, 2021 at 10:06 PM Adam Matan ***@***.***> wrote:
Hi, apologies for the late reply. Could you please help me understand the
usecase? Can it be exported to a KML?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO22OBZOVL4KX524WIBAERTTGL63TANCNFSM4WGDMBCA>
.
|
Owner
|
Dear Tendau, I do not see a picture attached - could you please repost? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for user to specify the height for the circle, and for example, use the result for to_lat_lon_height() as the outerboundary for the circle.