Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sample runners and four file-reading examples treat a file URL's pathname as a filesystem path. On Windows this produces an invalid drive path, and spaces in a checkout stay encoded as
%20, so the samples fail withENOENTbefore they can run.Convert those URLs with Node's
fileURLToPathbefore resolving sample directories. This gives the sample runners and examples native paths, including paths containing spaces.Testing: all five existing sample suites fail on the original source and pass with this change from a Windows checkout containing spaces (127 samples on Node 24.13.1). Changed-file ESLint passes. The suites were invoked directly through Mocha because the existing npm scripts' single-quoted globs do not work in Windows cmd.exe. The full package suites and other operating systems were not run for this change.