Add ql:has-word triples to internal PSO&POS permutation
#2579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 6, 2025 02:41
During parsing, for each triples with a literal object, and for each word in that literal, add an internal triple `subject ql:has-word "word"`. TODO: This is currently done unconditionally, which makes it easier to test (we don't need special options in the Qleverfile). Eventually, there should be an option `--add-has-word-triples` to `IndexBuilderMain` to enable this behavior. Tests are also still missing
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2579 +/- ##
=======================================
Coverage 91.20% 91.20%
=======================================
Files 473 473
Lines 40233 40264 +31
Branches 5378 5386 +8
=======================================
+ Hits 36695 36724 +29
- Misses 2006 2007 +1
- Partials 1532 1533 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Writing the position is more general. But computing the term frequencies for each text-word pair is currently not efficient in QLever (it requires too much memory and a GROUP BY with two variables is much slower than a GROUP BY with one variable). Since we never needed positions so far, but we do want term frequencies for scoring, let's make this the default for now.
hannahbast
added a commit
to qlever-dev/qlever-control
that referenced
this pull request
Dec 7, 2025
This complements ad-freiburg/qlever#2579
Overview
Conformance check passed ✅No test result changes. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During parsing, for each triples with a literal object, and for each word in that literal, add an internal triple
subject ql:has-word "word". These can be used for highly customized text search. To make this efficient, materialized views can be used.TODO: This is currently done unconditionally, which makes it easier to test (we don't need special options in the Qleverfile). Eventually, there should be an option
--add-has-word-triplestoIndexBuilderMainto enable this behavior. Tests are also still missing