GROUP_CONCAT with implicit string conversion
#2567
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most other RDF databases implement it this way. However, the standard seems to indicate that there is *no* implicit conversion to string (which is QLever's current behavior)
Overview
Conformance check passed ✅No test result changes. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2567 +/- ##
==========================================
- Coverage 91.13% 91.12% -0.01%
==========================================
Files 468 468
Lines 40073 40075 +2
Branches 5370 5371 +1
==========================================
+ Hits 36519 36520 +1
Misses 2023 2023
- Partials 1531 1532 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most other RDF databases implement it this way. However, the standard seems to indicate that there is no implicit conversion to string (which is QLever's current behavior). Addresses #806