Apply changes of various PRs by tarteo · Pull Request #4 · acsone/contract

tarteo · 2025-05-22T08:16:29Z

No description provided.

acsonefho · 2025-05-23T07:20:10Z

subscription_oca/data/sale_subscription_data.xml


    <data noupdate="1">
        <record id="subscription_stage_draft" model="sale.subscription.stage">
-            <!-- <field eval="True" name="active"/> -->


Please remove if useless

acsonefho · 2025-05-23T07:20:20Z

subscription_oca/data/sale_subscription_data.xml

        </record>

        <record id="subscription_stage_in_progress" model="sale.subscription.stage">
-            <!-- <field eval="True" name="active"/> -->


acsonefho · 2025-05-23T07:20:30Z

subscription_oca/data/sale_subscription_data.xml

        </record>

        <record id="subscription_stage_closed" model="sale.subscription.stage">
-            <!-- <field eval="True" name="active"/> -->


acsonefho · 2025-05-23T07:20:41Z

subscription_oca/data/sale_subscription_data.xml

    </data>

    <record id="close_reason_expensive" model="sale.subscription.close.reason">
-        <!-- <field eval="True" name="active"/> -->


acsonefho · 2025-05-23T07:20:45Z

subscription_oca/data/sale_subscription_data.xml

    </record>

    <record id="close_reason_requirement" model="sale.subscription.close.reason">
-        <!-- <field eval="True" name="active"/> -->


acsonefho · 2025-05-23T07:20:52Z

subscription_oca/data/sale_subscription_data.xml

    </record>

    <record id="close_reason_use" model="sale.subscription.close.reason">
-        <!-- <field eval="True" name="active"/> -->


acsonefho · 2025-05-23T07:20:56Z

subscription_oca/data/sale_subscription_data.xml

    </record>

    <record id="close_reason_other" model="sale.subscription.close.reason">
-        <!-- <field eval="True" name="active"/> -->


acsonefho · 2025-05-23T07:22:15Z

subscription_oca/models/account_move.py

+        action = self.env["ir.actions.act_window"]._for_xml_id(
+            "subscription_oca.sale_subscription_action"
+        )
+        action["domain"] = [("id", "=", self.subscription_id.id)]


I suppose the goal is to display the related form view.
You can use:
return self.subscription_id.get_formview_action()

acsonefho · 2025-05-23T07:22:58Z

subscription_oca/models/sale_subscription.py

        today = date.today()
-        for subscription in self.search([]):
+        for subscription in self.search([], order="recurring_next_date asc"):
+            subscription = subscription.with_company(subscription.company_id)


Good catch 💪

acsonefho · 2025-05-23T07:24:28Z

subscription_oca/models/sale_subscription.py

+        closed_stage = self.env["sale.subscription.stage"].search(
+            [("type", "=", "post")], limit=1
+        )
+        self.close_reason_id = close_reason_id


self.write({ "close_reason_id": close_reason_id, "stage_id": closed_stage.id, })

acsonefho · 2025-05-23T07:26:51Z

Thank you @tarteo for your contribution 💪 Just minor changes 🙏

tobiaszehntner · 2025-05-23T08:14:35Z

@tarteo we have to abandon our migration PR because we no longer need it and don't have the time. Feel free to apply the requested changes and create your own PR to 18, I think we're pretty close.

tarteo · 2025-05-23T11:07:25Z

Alright, well nonetheless thanks for your review and time! I'll apply your suggestions when I'll create a new PR. Have a nice weekend!

… account

[UPD] Update product_contract_variable_quantity.pot [UPD] README.rst

Currently translated at 100.0% (7 of 7 strings) Translation: contract-12.0/contract-12.0-product_contract_variable_quantity Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-product_contract_variable_quantity/it/

Currently translated at 100.0% (7 of 7 strings) Translation: contract-12.0/contract-12.0-product_contract_variable_quantity Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-product_contract_variable_quantity/pt_BR/

Currently translated at 100.0% (7 of 7 strings) Translation: contract-12.0/contract-12.0-product_contract_variable_quantity Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-product_contract_variable_quantity/pt/

…ate_id [UPD] README.rst [UPD] README.rst

Currently translated at 100.0% (7 of 7 strings) Translation: contract-12.0/contract-12.0-product_contract_variable_quantity Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-product_contract_variable_quantity/pt_BR/

Currently translated at 100.0% (7 of 7 strings) Translation: contract-12.0/contract-12.0-product_contract_variable_quantity Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-product_contract_variable_quantity/fr/

Currently translated at 95.7% (159 of 166 strings) Translation: contract-16.0/contract-16.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-subscription_oca/nl/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/

Currently translated at 100.0% (163 of 163 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/it/

Currently translated at 92.6% (151 of 163 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/fi/ Added translation using Weblate (Finnish)

Currently translated at 61.3% (100 of 163 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/tr/ Translated using Weblate (Turkish) Currently translated at 58.8% (96 of 163 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/tr/ Added translation using Weblate (Turkish)

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/

Currently translated at 100.0% (164 of 164 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/it/

Currently translated at 100.0% (164 of 164 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/tr/

[IMP] subscription_oca: Use read_group for subscription count Apply changes of OCA#1058 Apply changes of OCA#1224 Apply changes of OCA#1210 Apply changes of OCA#1167 subscription_oca: use get_formview_action Fix close_reason_id visibility Apply suggestions from review Add "odoo 18"-like icon

tarteo mentioned this pull request May 22, 2025

[18.0][MIG] subscription_oca: Migration to 18.0 from 17.0 OCA/contract#1209

Closed

tarteo added a commit to onesteinbv/addons-oca that referenced this pull request May 22, 2025

Migration of subscription_oca to 18.0

97d4e1c

OCA/contract#1209 + acsone/contract#4

tobiaszehntner requested a review from acsonefho May 22, 2025 12:15

acsonefho requested changes May 23, 2025

View reviewed changes

tobiaszehntner mentioned this pull request May 23, 2025

Migration to version 18.0 OCA/contract#1132

Open

24 tasks

tarteo force-pushed the 18.0-mig-subscription_oca branch 2 times, most recently from 105954a to 996eb61 Compare May 27, 2025 09:48

sbejaoui and others added 20 commits July 24, 2025 16:27

[IMP] - get contract line default data onchange product_id

69059aa

[IMP] - improve sale order line view

f3f689d

[FIX] - Fix unit tests

aef5446

[12.0][REF] - Product Contract Variable quantity: split from analytic…

036076e

… account

fix pylint

75716b1

[12.0][FIX] - Fix unit tests

b513e7e

[IMP] - Improve unit tests

ed539d7

[UPD] Update product_contract_variable_quantity.pot [UPD] README.rst

Added translation using Weblate (Italian)

d965947

Added translation using Weblate (Portuguese (Brazil))

27d2b51

Added translation using Weblate (Portuguese)

906de81

[FIX] product_contract_variable_quantity: use property_contract_templ…

b0ff325

…ate_id [UPD] README.rst [UPD] README.rst

[FIX] - remvoe unnecessary utf8 coding comment

5e08949

product_contract_variable_quantity 12.0.1.0.1

8f9b2a6

Added translation using Weblate (French)

26ca141

tarteo force-pushed the 18.0-mig-subscription_oca branch 2 times, most recently from baad433 to 150c702 Compare September 17, 2025 11:39

carlos-domatix and others added 27 commits September 17, 2025 13:52

[15.0][ADD] subscription_oca

1310db1

[IMP] subscription_oca: tests

6204825

[IMP] subscription_oca: refactoring

b58dfce

Added translation using Weblate (Spanish)

f6a812c

[MIG] subscription_oca: Migration to 16.0

f14f551

[IMP] subscription_oca: tests

b21c556

[IMP] subscription_oca: tests adjustments

fc9563f

[UPD] Update subscription_oca.pot

7b40e77

[BOT] post-merge updates

6618fd9

Added translation using Weblate (French)

4462d6b

Added translation using Weblate (Dutch)

f74cbed

Translated using Weblate (Dutch)

a08cc2d

Currently translated at 95.7% (159 of 166 strings) Translation: contract-16.0/contract-16.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-subscription_oca/nl/

Added translation using Weblate (Italian)

7ef95b4

[IMP] subscription_oca: pre-commit auto fixes

17770a1

[MIG] subscription_oca: Migration to 17.0

71b733a

[UPD] Update subscription_oca.pot

f922002

[BOT] post-merge updates

fd21e8c

Update translation files

4d5bcda

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/

Translated using Weblate (Italian)

35dfb35

Currently translated at 100.0% (163 of 163 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/it/

[UPD] Update subscription_oca.pot

a164f25

Update translation files

137ceb1

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/

Translated using Weblate (Italian)

afd5506

Currently translated at 100.0% (164 of 164 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/it/

Translated using Weblate (Turkish)

8a19f8f

Currently translated at 100.0% (164 of 164 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/tr/

[IMP] subscription_oca: pre-commit auto fixes

c9e295d

tarteo force-pushed the 18.0-mig-subscription_oca branch from 150c702 to 54f1d93 Compare September 17, 2025 11:52

Comments

Conversation

tarteo commented May 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

acsonefho commented May 23, 2025

Uh oh!

tobiaszehntner commented May 23, 2025

Uh oh!

tarteo commented May 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants