Skip to content

LORIS API client for real this time#1307

Closed
MaximeBICMTL wants to merge 1 commit into
aces:26.0-releasefrom
MaximeBICMTL:loris_api_client
Closed

LORIS API client for real this time#1307
MaximeBICMTL wants to merge 1 commit into
aces:26.0-releasefrom
MaximeBICMTL:loris_api_client

Conversation

@MaximeBICMTL

Copy link
Copy Markdown
Contributor

Description

This is the LORIS API client I am using on C-BIG for MPN.
This PR targets LORIS-MRI 26 as this is the LORIS version C-BIG is using, another PR for 27 or main will likely come later.
The client should be ready to use as-is, it is a completely standalone project that does not need the rest of LORIS-MRI to work (unlike the last PRs), see the README for installation and usage instructions.
There is very little documentation in the project itself, but it is typed and the user can usually refer to the broader LORIS API documentation.

I hesitated on whether to place this client in this repo, the LORIS repo, or a new repo, but I figured here would probably be the best, we will probably discuss this in a meeting.

Supersedes #1206

@MaximeBICMTL MaximeBICMTL force-pushed the loris_api_client branch 4 times, most recently from f310797 to eb70552 Compare July 3, 2025 02:05
@jeffersoncasimir

Copy link
Copy Markdown
Contributor

@MaximeBICMTL @cmadjar @ridz1208

Can this client instead be a standalone repo?

@ridz1208

ridz1208 commented Jul 7, 2025

Copy link
Copy Markdown

@jeffersoncasimir yes that's the plan!

@ridz1208

ridz1208 commented Jul 7, 2025

Copy link
Copy Markdown

@jeffersoncasimir

Copy link
Copy Markdown
Contributor

Sorry to be picky but I would recommend a rename to loris-python-client or loris-python-api-client.

This would be in line with aces/cbrain-php-client (used by EEGNet) and aces/cbrain-python-client.

@ridz1208

ridz1208 commented Jul 7, 2025

Copy link
Copy Markdown

@jeffersoncasimir Renaming things to be more like "CBRAIN" is not in my job description.

Also I figured that repo could host other clients than python? like a PHP client. Why need multiple repos for that.

And yes you are being picky 🙃

@MaximeBICMTL

MaximeBICMTL commented Jul 8, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for the repo @ridz1208 !

I personally have no strong opinion on the repository name. However, it is true that with loris-api-client, we kind of indicate that the Python client is the "canonical" LORIS API client (which I guess is kind of true). I guess we should discuss that in a meeting while no one depends on it yet. I also have a slight preference for kebab-case over snake_case as we use it for LORIS-MRI and it seems (to me) slightly more popular for git repos.

@MaximeBICMTL MaximeBICMTL added the Blocked Merge it and you die label Jul 8, 2025
@MaximeBICMTL

Copy link
Copy Markdown
Contributor Author

The new repository has been created here. We will discuss the naming in a meeting.

@MaximeBICMTL MaximeBICMTL removed the Blocked Merge it and you die label Jul 8, 2025
@cmadjar cmadjar added this to the NA milestone Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants