General - Optimize isNil/getVariable checks#11083
Draft
PabstMirror wants to merge 1 commit intomasterfrom
Draft
Conversation
rautamiekka
suggested changes
Oct 10, 2025
| if (isNull _object) exitWith {}; | ||
|
|
||
| if (_global && {isMultiplayer} && {isNil {_object getVariable QGVAR(initBoxJIP)}}) then { | ||
| if (_global && {isMultiplayer} && {(_object isNil QGVAR(initBoxJIP))}) then { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (_global && {isMultiplayer} && {(_object isNil QGVAR(initBoxJIP))}) then { | |
| if (_global && isMultiplayer && {_object isNil QGVAR(initBoxJIP)}) then { |
| }; | ||
|
|
||
| if (isNil {GVAR(sharedLoadoutsNamespace) getVariable QGVAR(sharedLoadoutsVars)}) then { | ||
| if ((GVAR(sharedLoadoutsNamespace) isNil QGVAR(sharedLoadoutsVars))) then { |
Contributor
There was a problem hiding this comment.
Suggested change
| if ((GVAR(sharedLoadoutsNamespace) isNil QGVAR(sharedLoadoutsVars))) then { | |
| if (GVAR(sharedLoadoutsNamespace) isNil QGVAR(sharedLoadoutsVars)) then { |
| }; | ||
|
|
||
| if (isNil {profileNamespace getVariable QGVAR(saved_loadouts)}) then { | ||
| if ((profileNamespace isNil QGVAR(saved_loadouts))) then { |
Contributor
There was a problem hiding this comment.
Suggested change
| if ((profileNamespace isNil QGVAR(saved_loadouts))) then { | |
| if (profileNamespace isNil QGVAR(saved_loadouts)) then { |
|
|
||
| // If items were set globally, do not add items locally | ||
| if (isNil {_object getVariable QGVAR(virtualItems)}) then { | ||
| if ((_object isNil QGVAR(virtualItems))) then { |
Contributor
There was a problem hiding this comment.
Suggested change
| if ((_object isNil QGVAR(virtualItems))) then { | |
| if (_object isNil QGVAR(virtualItems)) then { |
| }; | ||
| // check for pre-3.16 sway factors being added | ||
| if (!isNil {missionNamespace getVariable "ACE_setCustomAimCoef"}) then { | ||
| if (!(missionNamespace isNil "ACE_setCustomAimCoef")) then { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (!(missionNamespace isNil "ACE_setCustomAimCoef")) then { | |
| if !(missionNamespace isNil "ACE_setCustomAimCoef") then { |
|
|
||
| // Remove PFH if not sitting any more | ||
| if (isNil {_player getVariable QGVAR(sittingStatus)}) exitWith { | ||
| if ((_player isNil QGVAR(sittingStatus))) exitWith { |
Contributor
There was a problem hiding this comment.
Suggested change
| if ((_player isNil QGVAR(sittingStatus))) exitWith { | |
| if (_player isNil QGVAR(sittingStatus)) exitWith { |
| private _removeTimeLeft = _removeTime * _actualProgress; | ||
|
|
||
| if (isNil {_trench getVariable QGVAR(placeData)}) then { | ||
| if ((_trench isNil QGVAR(placeData))) then { |
Contributor
There was a problem hiding this comment.
Suggested change
| if ((_trench isNil QGVAR(placeData))) then { | |
| if (_trench isNil QGVAR(placeData)) then { |
| }; | ||
|
|
||
| if (!isNil {_vehicle getVariable QGVAR(handleDamage)}) exitWith {}; | ||
| if (!(_vehicle isNil QGVAR(handleDamage))) exitWith {}; |
Contributor
There was a problem hiding this comment.
Suggested change
| if (!(_vehicle isNil QGVAR(handleDamage))) exitWith {}; | |
| if !(_vehicle isNil QGVAR(handleDamage)) exitWith {}; |
| params ["_vehicle"]; | ||
|
|
||
| if (!isNil {_vehicle getVariable QGVAR(handleDamage)}) exitWith {}; | ||
| if (!(_vehicle isNil QGVAR(handleDamage))) exitWith {}; |
Contributor
There was a problem hiding this comment.
Suggested change
| if (!(_vehicle isNil QGVAR(handleDamage))) exitWith {}; | |
| if !(_vehicle isNil QGVAR(handleDamage)) exitWith {}; |
| TRACE_1("params",_unit); | ||
|
|
||
| if (isNil {_unit getVariable "ACE_airTemperatureBias"}) then { | ||
| if ((_unit isNil "ACE_airTemperatureBias")) then { |
Contributor
There was a problem hiding this comment.
Suggested change
| if ((_unit isNil "ACE_airTemperatureBias")) then { | |
| if (_unit isNil "ACE_airTemperatureBias") then { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.