Skip to content

Committing the homework#6

Open
Jmeggesto wants to merge 5 commits intoaccesscode-2-2:masterfrom
Jmeggesto:master
Open

Committing the homework#6
Jmeggesto wants to merge 5 commits intoaccesscode-2-2:masterfrom
Jmeggesto:master

Conversation

@Jmeggesto
Copy link
Copy Markdown

Committing my homework! Love you, Mike! Almost deleted the entire homework and had to start from scratch, but thankfully I recovered.

@Jmeggesto
Copy link
Copy Markdown
Author

Oh, important to note - the correct project is Unit1WeekFourHomework, not anything inside of the file marked "Homework" in the repo. I fucked something up with the thing I had in there initially, but it's fixed.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't gotten to your controller files yet, but your data model probably shouldn't have to know anything about index paths. I'll add additional comments if I see this come up later on.

@cspickert
Copy link
Copy Markdown

Nice work. The only major suggestion I can think of is to make sure your data model doesn't know too much about the rest of your app (i.e. you shouldn't store index paths in your data model because they're specific to table/collection views). It's not a huge deal for a very small app like this one, but when you start working on anything even slightly more complicated, it becomes much more important to maintain that separation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants