Skip to content

sorry mike i love you#33

Open
ddistant wants to merge 1 commit intoaccesscode-2-2:masterfrom
ddistant:master
Open

sorry mike i love you#33
ddistant wants to merge 1 commit intoaccesscode-2-2:masterfrom
ddistant:master

Conversation

@ddistant
Copy link
Copy Markdown

im so sorry please forgive me

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style: Try to keep your vertical spacing consistent (there should be one empty line between the last @property and @end).

@cspickert
Copy link
Copy Markdown

Nice work overall. I think the biggest problem I'm seeing is that OSCategoriesTableViewController knows too much about the way OSStuffTableViewController is implemented. A good place to start reworking things would be to avoid having OSCategoriesTableViewController rely on the fact that OSStuffTableViewController uses a table view at all. That would force you to explore other ways of passing data between the two objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants