added the possibility to manage animations#1
Open
biou wants to merge 5 commits intoaccess42:masterfrom
Open
Conversation
|
This MR looks good to me. It's working as expected and I like that there is a callback for JS to react to the change. |
Author
Thanks for your support! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It might be interesting to add an option in AccessConfig to manage animations. This has been done in the accessibility parameters of other websites, for example sncf.fr.
Compared to other AccessConfig parameters, animations can often be managed by JavaScript, so we should find a way to notify this code of some changes in the settings. There are several ways to do this, I propose to use a callback function, mainly because it is simple to use and does not need a polyfill like custom events in old versions of IE.
What do you think, is it interesting?