Skip to content

Add parameter to manage puppetmaster service status - #171

Open
jordigg wants to merge 4 commits into
abstractitptyltd:productionfrom
jordigg:puppetmaster_ensure
Open

jordigg wants to merge 4 commits into
abstractitptyltd:productionfrom
jordigg:puppetmaster_ensure

Conversation

@jordigg

@jordigg jordigg commented May 4, 2018

Copy link
Copy Markdown
Contributor

Add parameter to manage puppetmaster service status. This way the module can manage if puppetserver should be running or not.
By default will be running but it can be stopped if needed, for example when used on a docker instance.

@jordigg

jordigg commented May 4, 2018

Copy link
Copy Markdown
Contributor Author

@rendhalver when do you think a new release is going to be done? This would help/unblock us big time.

@rendhalver

rendhalver commented May 4, 2018 •

Copy link
Copy Markdown
Member

Sounds like a useful addition.
Give me a bit to review and I will see what I can do about pushing out a new release.
Have you tested this in your environment?

@jordigg

jordigg commented May 4, 2018

Copy link
Copy Markdown
Contributor Author

Thanks a lot, I've got a workaround working by installing dependencies manually and then installing the module from a .tar.gz so no rush on the release if not needed.
I'm using the module on a docker puppetserver to let puppet set itself up rather than hardcode all the setting on the dockerfile/bootstrap-scripts.

@rendhalver

Copy link
Copy Markdown
Member

I am going to keep this open till I can make that new release.
Please remind me if I haven't gotten to it in a day or so.

@jordigg

jordigg commented May 21, 2018

Copy link
Copy Markdown
Contributor Author

@rendhalver Sorry to bother, are you going to make a release soon? I want to check and try and get hiera5 support as well in this module.

@rendhalver

Copy link
Copy Markdown
Member

Thanks for the reminder.
I will get that done soon.
It works pretty well with hiera5 already.

service { 'puppetserver':
ensure => 'running',
enable => true,
ensure => $service_enable,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will setting this to true work with all versions?
Some may not like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants