Stringify error message in subscription onError#62
Open
matrinox wants to merge 1 commit into
Open
Conversation
By default we should show an error that the engineer can immediately understand
Contributor
|
Graphql spec says error message should be string and there is an extensions field to provide additional context about the error (#29 (comment)), I would prefer to take this route and add support to the extensions field. Would it be possible for you to return the error context in the extensions field instead? |
Author
|
@mgtitimoli sure, let me investigate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default we should show an error that the engineer can immediately understand