Revert "Manually copy Uppy resources to fix issues with Yarn v1." #24728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6939e30.
EngincanV
approved these changes
Jan 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the previous change that manually vendored Uppy distribution assets into @abp/uppy, switching back to consuming Uppy’s upstream package and mapping its dist output to ABP’s /libs/uppy path.
Changes:
- Add
uppyas a dependency of@abp/uppy. - Remove vendored
distassets from the@abp/uppypack. - Update ABP resource mapping to copy from
node_modules/uppy/distinstead ofnode_modules/@abp/uppy/dist.
Reviewed changes
Copilot reviewed 2 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| npm/packs/uppy/package.json | Adds the upstream uppy dependency so the pack can source assets from node_modules/uppy. |
| npm/packs/uppy/dist/uppy.css.map | Removes vendored Uppy source map asset as part of reverting local bundling. |
| npm/packs/uppy/dist/uppy.css | Removes vendored Uppy CSS asset as part of reverting local bundling. |
| npm/packs/uppy/dist/README.md | Removes vendored Uppy README from the pack’s dist directory. |
| npm/packs/uppy/abp.resourcemapping.js | Updates resource mapping to publish /libs/uppy/* from uppy/dist in node_modules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6939e30.