Skip to content

Fix presence auto re-enter error message missing clientId (RTP17e) #2314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ttypic merged 2 commits into from
Oct 20, 2026
Merged

Fix presence auto re-enter error message missing clientId (RTP17e) #2314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6d9041
Fix presence auto re-enter error message missing clientId (RTP17e)
cpruijsen Sep 28, 2026
4946088
Merge branch 'main' into fix/issue-2209
ttypic Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/common/lib/client/realtimepresence.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ class RealtimePresence extends EventEmitter {
const id = entry.connectionId === connId ? entry.id : undefined;
this._enterOrUpdateClient(id, entry.clientId, entry.data, 'enter').catch((err) => {
const wrappedErr = new ErrorInfo({
message: 'Presence auto re-enter failed',
message: 'Presence auto re-enter failed for clientId "' + entry.clientId + '"',
code: 91004,
statusCode: 400,
cause: err,
Expand Down
10 changes: 0 additions & 10 deletions test/uts/deviations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,6 @@ These tests assert spec behavior but are skipped by default because they are kno

---

### presence_reentry: RTP17e - re-entry error message missing clientId

**Spec (RTP17e)**: Failed re-entry should emit UPDATE with error code 91004 and message indicating the failure and clientId.

**ably-js behavior**: The error message is `'Presence auto re-enter failed'` without including the clientId.

**Test**: `RTP17e - failed re-entry emits UPDATE with error` — asserts `message.includes('my-client')` per spec.

---

### connection_ping: RTN13d - ping does not defer in non-connected states

**Spec (RTN13d)**: Ping should be deferred until the connection reaches a resolvable state.
Expand Down
1 change: 0 additions & 1 deletion test/uts/realtime/unit/presence/realtime_presence_reentry.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,6 @@ describe('uts/realtime/unit/presence/realtime_presence_reentry', function () {
*/
// UTS: realtime/unit/RTP17e/failed-reentry-emits-update-error-0
it('RTP17e - failed re-entry emits UPDATE with error', async function () {
if (!process.env.RUN_DEVIATIONS) this.skip(); // ably-js error message doesn't include clientId
const channelName = `test-RTP17e-${Date.now()}`;
let connectionCount = 0;

Expand Down
Loading