Stop duplicating "Press Ctrl+C to exit." in holding messages#379
Merged
umair-ably merged 1 commit intomainfrom Apr 27, 2026
Merged
Stop duplicating "Press Ctrl+C to exit." in holding messages#379umair-ably merged 1 commit intomainfrom
umair-ably merged 1 commit intomainfrom
Conversation
formatListening (utils/output.ts) auto-appends "Press Ctrl+C to exit." to whatever description it gets, and logHolding/logListening route through it. But every logHolding call site — and one logListening call site in channels/presence/enter — passed a message that already ended with that suffix, so the rendered text doubled it: Holding presence. Press Ctrl+C to exit. Press Ctrl+C to exit. Strip the manual suffix from each affected call site. The helper still appends it once. logListening callers elsewhere already follow this shape (e.g. "Listening for messages." with no manual suffix), so this just brings the holding-style sites into line with the established convention.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Walkthrough
Changes
Review Notes
|
AndyTWF
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatListening(src/utils/output.ts:18) auto-appends "Press Ctrl+C to exit." to the message it gets, andlogHolding/logListening(src/base-command.ts) both route through it.logHoldingcall site — and onelogListeningsite inchannels/presence/enter— passed a message that already ended with the same phrase, so the rendered output doubled it:Holding presence. Press Ctrl+C to exit. Press Ctrl+C to exit.logListeningcallers already follow elsewhere (e.g."Listening for messages.").Test plan
pnpm preparebuilds cleanpnpm exec eslint .— 0 errorspnpm test:unit— 2295 passed, 1 skipped, 1 todoably rooms presence enter chatand confirm the holding line readsHolding presence. Press Ctrl+C to exit.(single suffix)