Skip to content

fix(deps): bump @inquirer/prompts from 5.5.0 to 8.4.2#378

Merged
umair-ably merged 2 commits intomainfrom
dependabot/npm_and_yarn/inquirer/prompts-8.4.2
May 8, 2026
Merged

fix(deps): bump @inquirer/prompts from 5.5.0 to 8.4.2#378
umair-ably merged 2 commits intomainfrom
dependabot/npm_and_yarn/inquirer/prompts-8.4.2

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Apr 27, 2026

Bumps @inquirer/prompts from 5.5.0 to 8.4.2.

Release notes

Sourced from @​inquirer/prompts's releases.

@​inquirer/prompts@​8.4.2

  • Fix: some Windows terminals would freeze and not react to keypresses.

@​inquirer/prompts@​8.4.1

  • Improve expand prompt type inferrence.

@​inquirer/prompts@​8.4.0

  • Feat: Added a loading message while validating editor prompt input.
  • Type improvement: Better type inference with checkbox, search and expand prompts.
  • Fix: editor prompt not always properly handling editor path on windows.

@​inquirer/prompts@​8.3.2

  • Fix broken 8.3.1 release process.

@​inquirer/prompts@​8.3.1

  • Bump dependencies

@​inquirer/prompts@​8.3.0

  • Fix: Keypresses happening before a prompt is rendered are now ignored.
  • Fix (checkbox): Element who're both checked and disabled are now always included in the returned array.
  • Feat (select/checkbox): Cursor will now hover disabled options of the list; but they still cannot be interacted with. This prevents the cursor jumping ahead in ways that can be confusing.
  • Feat: various new theme options to make all prompts content localizable.

Finally, see our new @inquirer/i18n package!

@​inquirer/prompts@​8.2.1

  • chore: Switch wrap-ansi with fast-wrap-ansi

@​inquirer/prompts@​8.2.0

  • feat(search): Add support for default.
  • feat(rawlist): Add support for description of choices. That information is displayed under the list when the choice is highlighted.
  • Bump dependencies

@​inquirer/prompts@​8.1.0

  • Feat: rawlist now supports default option.
  • Fix: select now infer return type properly when passing a choices array of string literals.

@​inquirer/prompts@​8.0.2

  • Fix Typescript not discovering types when moduleResolution is set to commonjs (you probably want to fix that in your project if it's still in your tsconfig)

@​inquirer/prompts@​8.0.0

Release Notes

🚨 Breaking Changes

This is a major release that modernizes the codebase for Node.js ≥ 20.

ESM Only - No More CommonJS Support

Impact: All packages are now ESM-only. CommonJS imports are no longer supported.

... (truncated)

Commits
  • 35bda2a chore: Publish new release
  • 98eee29 fix(lint): suppress no-unnecessary-type-parameters on parseJSON helper
  • aba5965 chore(deps-dev): Bump @​types/node in the types group (#2088)
  • db8fbf1 chore(deps-dev): Bump turbo from 2.9.5 to 2.9.6 in the build group (#2087)
  • 3cdecf5 chore(deps-dev): Bump oxfmt in the formatting group (#2086)
  • e370b57 chore(deps-dev): Bump the linting group with 5 updates (#2085)
  • 2787267 chore(deps-dev): Bump the testing group with 3 updates (#2084)
  • 0c55499 chore(deps-dev): Bump the formatting group with 2 updates (#2081)
  • e7115d9 fix(@​inquirer/core): mute output after readline initialization (#2077)
  • e5e14ab chore(deps): Bump dependabot/fetch-metadata from 2 to 3 (#2078)
  • Additional commits viewable in compare view

@dependabot dependabot Bot added the dependencies Pull requests that update a dependency file label Apr 27, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cli-web-cli Ready Ready Preview, Comment May 8, 2026 11:33am

Request Review

@ci-lockfile-regen
Copy link
Copy Markdown

Dependabot Fix Assessment

Package: `@inquirer/prompts` `5.5.0` → `8.4.2` (major)
Scope: runtime dependency
Workspace: root

What changed upstream

  • In v6+, @inquirer/prompts prompts no longer return a CancelablePromise — they return a plain Promise<Value>. The .cancel() method was removed from the returned promise object.
  • Cancellation is now handled by passing an AbortSignal via the context (second) argument: confirm(config, { signal }). Aborting the signal cancels the prompt.

Migration concerns checked

  • Peer dependencies: OK
  • Type changes: The Prompt<Value, Config> type now returns Promise<Value> (was CancelablePromise<Value>). Confirmed in node_modules/@inquirer/type/dist/*.d.ts.
  • Config files: OK
  • Module format: OK
  • React compatibility: N/A
  • Monorepo impact: OK — @inquirer/prompts is only used in the root package

What broke

  • All CI checks: TypeScript compile error TS2339: Property 'cancel' does not exist on type 'Promise<boolean>'src/hooks/command_not_found/prompt-utils.ts:27

What was fixed

  • Passed the existing AbortSignal as the context argument to confirm(config, { signal }) so aborting the controller cancels the prompt.
  • Replaced .then(() => confirmation.cancel()) with .then(() => ac.abort()) in the timeout chain.

Verification

  • Build: ✅
  • Lint: ✅
  • Unit tests: ✅
  • Web CLI tests: N/A (not applicable to this change)

Notes for reviewer

The abort flow is unchanged in semantics: the 10-second timeout fires → ac.abort() is called → the AbortSignal cancels the confirm prompt → the catch block returns false. When the user responds before the timeout, the finally block calls ac.abort() which cancels the pending setTimeout. Functionally identical to the old CancelablePromise.cancel() behaviour.

@ci-lockfile-regen
Copy link
Copy Markdown

Dependabot Fix Assessment

Package: `@inquirer/prompts` `5.5.0` → `8.4.2` (major bump — 3 major versions)
Scope: runtime dependency (`dependencies`)
Workspace: root

What changed upstream

  • Breaking (v6+): confirm() and other prompts now return plain Promise<Value> instead of CancelablePromise. The .cancel() method no longer exists.
  • New cancellation API: Pass { signal: AbortSignal } as the second argument to prompts to support cancellation via AbortController.
  • Breaking (v8.0.0): ESM-only — no more CommonJS. Not a concern for this repo ("type": "module" already set).
  • v8.3.0: Keypresses before a prompt renders are now ignored (no impact here).
  • v8.4.2: Fix for Windows terminal freeze (no impact here).

Migration concerns checked

  • Peer dependencies: OK — no new peer deps required
  • Type changes: OK — Promise<boolean> vs CancelablePromise<boolean>; handled by removing .cancel() usage
  • Config files: OK — no config file changes needed
  • Module format: OK — repo is already ESM-only
  • React compatibility: N/A — not a React ecosystem change
  • Monorepo impact: OK — @inquirer/prompts is only used in the root package (src/hooks/command_not_found/prompt-utils.ts), not in packages/react-web-cli or examples/web-cli

What broke

  • src/hooks/command_not_found/prompt-utils.ts: Called .cancel() on the CancelablePromise returned by confirm() to abort the 10-second timeout. In v8, confirm() returns a plain Promise, so .cancel() doesn't exist.

What was fixed

  • Passed { signal } from an AbortController as the second argument to confirm().
  • Replaced confirmation.cancel() with ac.abort() in the timer callback and finally block.
  • No other files use @inquirer/prompts.

Verification

  • Build: ✅ (pnpm prepare clean)
  • Lint: ✅ (0 errors)
  • Unit tests: ✅ (2295 passing)
  • Web CLI tests: ✅ (57 passing)

Notes for reviewer

The CI failure in Web CLI E2E Tests — "should handle disconnection and reconnection gracefully" is not caused by this dependency bump. Analysis:

  1. @inquirer/prompts is only used in the command_not_found hook, which runs only when a user types an unknown command.
  2. The failing E2E test only types --version and help (both valid commands), so the @inquirer/prompts code path never executes during that test.
  3. No changes were made to packages/react-web-cli or examples/web-cli.
  4. The failure is a timing race: the React component sets componentConnectionStatus = "connected" based on a server message, but the underlying WebSocket's readyState has since transitioned out of OPEN before the test sends its next command. This is pre-existing reconnection timing flakiness unrelated to this PR.
  5. The other three reconnection tests in the same suite all passed in that same CI run.

@umair-ably
Copy link
Copy Markdown
Collaborator

@dependabot recreate

Bumps [@inquirer/prompts](https://github.com/SBoudrias/Inquirer.js) from 5.5.0 to 8.4.2.
- [Release notes](https://github.com/SBoudrias/Inquirer.js/releases)
- [Commits](https://github.com/SBoudrias/Inquirer.js/compare/@inquirer/prompts@5.5.0...@inquirer/prompts@8.4.2)

---
updated-dependencies:
- dependency-name: "@inquirer/prompts"
  dependency-version: 8.4.2
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/inquirer/prompts-8.4.2 branch from add363a to bb2b5dc Compare May 8, 2026 11:20
@inquirer/prompts v8 removed the `.cancel()` method from prompt return
values. Cancellation is now handled by passing an AbortSignal via the
second `context` argument to each prompt function.

Also removes the `instructions` option from the `checkbox()` call which
was removed in v8 — key hints are now rendered automatically via the
theme's `keysHelpTip` style function.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ci-lockfile-regen
Copy link
Copy Markdown

Dependabot Fix Assessment

Package: `@inquirer/prompts` `5.5.0` → `8.4.2` (major)
Scope: runtime dependency
Workspace: root

What changed upstream

  • v6+ removed the .cancel() method on prompt return values. Cancellation is now performed by passing an `AbortSignal` via the second `context` argument to each prompt function (`confirm(config, { signal })`, `checkbox(config, { signal })`, etc.)
  • v8 removed the `instructions` config option from `checkbox()`. Key hints (space to toggle, a for all, enter to confirm) are now rendered automatically by the theme's `style.keysHelpTip` function.

Migration concerns checked

  • Peer dependencies: OK
  • Type changes: OK (the two breaking type errors are what we fixed)
  • Config files: OK
  • Module format: OK
  • React compatibility: N/A
  • Monorepo impact: OK (only root package uses `@inquirer/prompts`)

What broke

  • TypeScript error in `src/hooks/command_not_found/prompt-utils.ts:27`: Called `.cancel()` on the return value of `confirm()`, which is now a plain `Promise` with no such method.
  • TypeScript error in `src/services/skills-target-prompt.ts:85`: Passed `instructions` option to `checkbox()`, which no longer exists in the config type.

What was fixed

  • `prompt-utils.ts`: Replaced single `AbortController` + `.cancel()` pattern with two controllers — one passed as `{ signal }` to `confirm()` context (aborts the prompt), and one passed as `{ signal }` to the `setTimeout` timer (cancelled when user answers). The 10-second auto-timeout behaviour is preserved.
  • `skills-target-prompt.ts`: Removed the `instructions` property. The v8 checkbox renders equivalent key hints automatically via its default theme.

Verification

  • Build: ✅
  • Lint: ✅ (0 errors)
  • Unit tests: ✅ (2479 passed)
  • Web CLI tests: N/A (not run locally)

Notes for reviewer

  • The behavioural contract is unchanged: confirmation prompt auto-cancels after 10 s; checkbox shows key hints. Only the API surface for driving these behaviours changed.

message: "Which editor(s) would you like to configure?",
choices,
instructions:
" (Press <space> to toggle, <a> to toggle all, <enter> to confirm)",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

tested this locally and this removed text is now replaced with this

@umair-ably umair-ably merged commit 6735111 into main May 8, 2026
12 checks passed
@umair-ably umair-ably deleted the dependabot/npm_and_yarn/inquirer/prompts-8.4.2 branch May 8, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Development

Successfully merging this pull request may close these issues.

1 participant